fix: prevent image preview for null/undefined image values - #5293
Open
dajiaohuang wants to merge 2 commits into
Open
fix: prevent image preview for null/undefined image values#5293dajiaohuang wants to merge 2 commits into
dajiaohuang wants to merge 2 commits into
Conversation
When image column cell value is null, undefined, or empty string, clicking the cell should not open the broken image preview dialog. Fixes VisActor#5290
Contributor
建议把同类问题也处理下 @dajiaohuang
|
Contributor
Author
|
已按建议把同类问题一起处理：音频和视频预览分支现在也会在空值时直接返回，提交为 同时新增了 image/audio/video 三类空值回归测试。验证结果：
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When image column cell value is null, undefined, or empty string, clicking the cell should not open the broken image preview dialog.
Root Cause
In
media-click.ts, the image click handler did not check if the cell value was valid before creating the preview image. This caused broken images to be displayed when clicking on cells with null/undefined values.Fix
Add a check for falsy
cellValuebefore proceeding with the image preview.Testing
Related Issue
Fixes #5290