Fix/add row column plugin release error#5141
Open
wkeylin wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
fixed #5140
💡 Background and solution
AddRowColumnPlugin 的 release() 方法中直接调用了 this.leftDotForAddColumn.remove() 等 8 个 UI 元素的 remove() 方法。但这些 UI 元素(如 leftDotForAddColumn、rightDotForAddColumn、addIconForAddColumn 等)是在用户交互过程中懒创建的,如果插件在这些元素被创建之前就调用了 release()(例如初始化后直接销毁表格),这些属性为 undefined,导致抛出 Cannot read properties of undefined (reading 'remove') 错误。
在 release() 方法中对所有 UI 元素的 remove() 调用添加可选链操作符 ?.,确保元素未初始化时安全跳过,不会抛出异常
📝 Changelog
☑️ Self-Check before Merge
🚀 Summary
copilot:summary
🔍 Walkthrough
copilot:walkthrough