Repository navigation
Fix stale and inherited collection parameter detection; build it at compile time - #2724
Merged
joelhawksley merged 1 commit intoOct 15, 2026
Conversation
joelhawksley
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #2722 and #2723 (comment). While working on the collection introspection, I found two caching bugs, and the cached state wasn't Ractor-safe.
A subclass could inherit its parent's default collection parameter name.
__vc_collection_parameterstored the computed default into@__vc_provided_collection_parameter, the same ivarwith_collection_parametersets, andinheritedcopies that ivar to subclasses. So the result depended on load order:With eager loading, subclasses usually load before anything renders, so production and development could behave differently.
Recompiling didn't refresh the detection. The memoized parameter names and counter/iteration answers were never cleared, so a forced recompile (e.g. development reloading, or a
prependadded after the first render) kept stale results.Other details
||=writes are replaced by a single build that runs when the component compiles. If a class hasn’t been compiled yet, the first read builds it, so with eager loading every write happens at boot on the main Ractor.