Feat: added support for custom blocks on Bedrock.#1177
Conversation
|
This PR is ready for review. |
|
currently every block states is a different block, we should split this into states instead of doing that, if anyone wanna take a crack at it then feel free, marking this as draft. |
|
dude this is awesome!!!! |
|
ikr |
|
The PR looks overall good, but we have to clarify the maintenance aspect here. How active are you going to maintain this feature? It's introducing a bunch of code changes to the game which I'm not sure of capable updating on game updates (and making sure it continues to work). Maybe we will need to find a way to isolate bedrock only features before merging. |
I am more than willing to actively maintain it :P, however isolating it also is a good idea I think. |
|
Sounds good, though then it would make sense to get you into the discord chat again (so we can do some more rapid chatting). I don't have the capacity to go more closely over this at the moment, so this will be something for after 26.2. |
|
sound good to me. |
| final JsonObject jsonObject = element.getAsJsonObject(); | ||
| final JsonElement textures = jsonObject.get("textures"); | ||
| if (textures instanceof JsonPrimitive primitive) { | ||
| final Map<Direction, String> map = new HashMap<>(); |
There was a problem hiding this comment.
EnumMap could be better?
| } | ||
| ID_TO_TEXTURE_MAP.put(key, map); | ||
| } else if (textures instanceof JsonObject texturesObject) { | ||
| final Map<Direction, String> map = new HashMap<>(); |
| return null; | ||
| } | ||
|
|
||
| final Map<Direction, String> map = new HashMap<>(); |
4 participants
This PR adds support for custom blocks on Bedrock, nothing more!
Current TODO: