[VEN-3338] Configure TreasuryConverter on BSC, Ethereum, Arbitrum#596
Open
Exef wants to merge 3 commits intofeat/VEN-3328from
Open
[VEN-3338] Configure TreasuryConverter on BSC, Ethereum, Arbitrum#596Exef wants to merge 3 commits intofeat/VEN-3328from
Exef wants to merge 3 commits intofeat/VEN-3328from
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Debugger022
reviewed
Jul 30, 2025
Contributor
|
Can you please include simulations for
|
chechu
reviewed
Jul 31, 2025
vips/vip-536/bscmainnet.ts
Outdated
| signature: "setConversionConfigs(address,address[],(uint256,uint8)[])", | ||
| params: [ | ||
| TREASURY_CONVERTER.bscmainnet.tokenIn, | ||
| TREASURY_CONVERTER.bscmainnet.tokenOuts, |
Contributor
There was a problem hiding this comment.
These must be the addresses of every underlying asset supported on BNB Chain, except the tokenIn and the assets we want to directly transfer to the destination contract
chechu
reviewed
Jul 31, 2025
Contributor
There was a problem hiding this comment.
We also need the bsctestnet commands and simulations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolves VEN