feat: add guide to Dashboard page#5258
Conversation
🦋 Changeset detectedLatest commit: 94388e1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
0030779 to
3686ed2
Compare
3686ed2 to
5a9f18e
Compare
0139ee3 to
34b49d8
Compare
5a9f18e to
4dd12f6
Compare
4dd12f6 to
ea9dfc0
Compare
34b49d8 to
1034958
Compare
| "guide": { | ||
| "completed": "已完成", | ||
| "step1": { | ||
| "description": "通过供应资产或将现有头寸迁移到 Venus 协议来赚取收益。", |
There was a problem hiding this comment.
This Chinese translation looks weird. Might need to consult Zad for a more accurate translation.
| "guide": { | ||
| "completed": "已完成", | ||
| "step1": { | ||
| "description": "透過供應資產或將現有部位遷移到 Venus 協議來賺取收益。", |
| "title": "供应 / 迁移" | ||
| }, | ||
| "step2": { | ||
| "description": "借入资产增强您的 DeFi 策略,或一键使用流动性进行杠杆操作。", |
There was a problem hiding this comment.
I believe there should be better wording in Chinese, since this is too obvious for auto-translated.
|
|
||
| return ( | ||
| <> | ||
| {/* Mobile UI */} |
There was a problem hiding this comment.
Why not using conditional rendering instead? Having both rendered seems unnecessary and reduce performance especially the Carousel.
There was a problem hiding this comment.
I agree it makes sense here.
In general I use CSS, even if it means duplicating some DOM, just to stick to the Tailwind way of doing things. But in this case it's true that it means we display a heavy component for nothing. I'll update the code.
ae7cb03 to
133850e
Compare
|
Thank you guys, I've updated the translations according to your suggestions. |
133850e to
edfd0fd
Compare
edfd0fd to
d67191a
Compare
d67191a to
94388e1
Compare
Jira ticket(s)
VPD-415
Changes
evm app