Ship the extractor as one flat folder with a stamped README - #3
Open
xusheng6 wants to merge 2 commits into
Open
Conversation
The three files are vendored as a unit -- the executable reads the index from beside itself -- so the artifact is now flat rather than nested under an architecture, named ttd-extract, with the reference doc as the README of the folder it lands in. CI appends the repo, commit and date to that README, so provenance travels with the binary instead of being a note someone has to remember to update.
On a pull_request build GITHUB_SHA is a throwaway merge commit and GITHUB_REF_NAME is "<n>/merge", so the provenance footer named something nobody can check out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The three files are vendored as a unit, so the artifact is flat rather than nested under an architecture, named
ttd-extract, with the reference doc as the folder'sREADME.md.CI stamps the repo, commit and date onto that README so provenance travels with the binary rather than being a note someone has to remember to update.