Version and Platform (required):
- Binary Ninja Version: 6.1.10679
- Edition: Ultimate
- OS: macOS
- OS Version: 27.0
- CPU Architecture: M5
Bug Description:
Plugins can currently override OnTokenDoubleClicked to perform custom handling of double-clicking tokens. The debugger uses this to provide custom handling of token navigation that is debugger aware. With the unified navigation between double-clicking and pressing Enter on a token, Enter also goes through this path. However, a press of Enter (or any other way of using the Activate Selection action) goes through the validity callback, which is fixed and cannot be overridden by plugins. If the original implementation says a token has associated navigation, it will pass through to a plugin, but one that was not marked as having navigation will never call into the plugin along the action path (double-clicking sidesteps this entire path and works in all cases). As it stands, double-click and Enter are not the same thing when a plugin adds functionality, as some kinds of additional token handling plugins provide may not be reachable using the Enter/Activate Selection path.
Version and Platform (required):
Bug Description:
Plugins can currently override
OnTokenDoubleClickedto perform custom handling of double-clicking tokens. The debugger uses this to provide custom handling of token navigation that is debugger aware. With the unified navigation between double-clicking and pressing Enter on a token, Enter also goes through this path. However, a press of Enter (or any other way of using theActivate Selectionaction) goes through the validity callback, which is fixed and cannot be overridden by plugins. If the original implementation says a token has associated navigation, it will pass through to a plugin, but one that was not marked as having navigation will never call into the plugin along the action path (double-clicking sidesteps this entire path and works in all cases). As it stands, double-click and Enter are not the same thing when a plugin adds functionality, as some kinds of additional token handling plugins provide may not be reachable using the Enter/Activate Selection path.