fix(optimizer): preserve Unicode heading keys - #546
Open
rudycelekli wants to merge 1 commit into
Open
rudycelekli wants to merge 1 commit into
rudycelekli wants to merge 1 commit into
Conversation
Signed-off-by: Rudy Celekli <47457359+rudycelekli@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Flash expansion currently strips every non-ASCII letter from its comparison keys. Printed Japanese subsection titles then become empty strings and are rejected as identical to the parent; an absent non-ASCII title can also match any page beneath an ASCII parent. Preserve Unicode letters and numbers while retaining the existing lowercase, whitespace, punctuation and underscore handling.
Add four public
page_index_flashregressions using generated Japanese and ASCII PDFs. They exercise native PDF parsing, bookmarks and optimization, with only external completion responses stubbed. The cases check printed heading extraction, duplicate/parent/absent-title rejection, and page ranges when a subsection starts at the top or midway through a page.Validation:
git diff --checkpassed. No real model calls were made.