Row opacity compounding, and the test count this repo stated twice - #30
Merged
Merged
Conversation
…twice
Two things, both a number or a rule that nothing checked.
The CSS. `.row span { opacity: .7 }` matched more than the tag it was
written for: `.t` is itself a span wrapping the title and the tag, so
the selector applied to the tag twice (0.7 x 0.7 = 0.49) and to the
title once. On this landing page that put 12 tags at #84827f on
#f6f2ea, 3.43:1 at 10.56px against AA's 4.5:1, and dimmed 12 row titles
that `.row b { font-weight: 600 }` exists to make prominent. Scoped to
`.row .t > span`: tag 6.98:1, title 17.39:1, hover 8.68:1.
assets/css/stack.css is byte-identical across the four stack
repositories by design, so the change lands in all four. Counted before:
InsightStack 18 elements, EquityStack 12, SignalStack 7, FieldStack 0
(different markup on its landing page). After, on all four: 0 serious
or critical axe violations at 1280x900 and 390x844, no overflow.
The test count. CLAUDE.md's Testing section said 25 tests and the
header comment in requirements.txt said 25, while CLAUDE.md's own
Layout section fifteen lines earlier said 101. The suite is 101, run
today against the pinned set on Python 3.11. Two numbers for one suite
in one repository, disagreeing with each other and with pytest, and
nothing compared any of them.
Both corrected to 101, with a line recording that the disagreement was
there and unnoticed. Note the suite still emits pydantic @validator
deprecation warnings, which CLAUDE.md already flags: the pin holds
pydantic at 2.13.5 and @validator is removed in 3, so whoever raises it
moves those to @field_validator in the same change.
Also checked while here: pip-audit over the pinned set reports no known
vulnerabilities. It flags setuptools 79.0.1, which is the venv's own
build tooling and is required by nothing in requirements.txt except
under dev, testing and build extras.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MrvR2NXsJFVRCeJZFCPuNL
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
.row spanin the sharedstack.csstook an opacity on top of a token that had already been measured, which put the language tags under AA on the landing page.The suite has 101 tests.
CLAUDE.md's Testing section said 25, and so did the header comment inrequirements.txt, while the Layout section of the same file said 101. Two numbers for one suite, in one repository, and nothing compared either againstpytest. The count is read off a run now and stated once.Type of change
Checklist
PYTHONPATH=$(pwd) pytest tests/— 101 passed on Python 3.11 against the pinned setCommits
🤖 Generated with Claude Code
https://claude.ai/code/session_01MrvR2NXsJFVRCeJZFCPuNL
Generated by Claude Code