feat(ui): report annotation-stream variants the server could not annotate - #713
Merged
bencap merged 1 commit intoAug 12, 2026
Conversation
|
Coverage is 10.274% — chore/bencap/export-hardening into feature/bencap/447/gnomad-allele-frequency. No base build found for |
bencap
force-pushed
the
chore/bencap/export-hardening
branch
from
August 11, 2026 16:27
dc24a8c to
07b14c6
Compare
…tate The API now reports a variant it cannot annotate as a record carrying an error object instead of letting the exception truncate the body. A download containing those records is complete and worth saving, but treating it as a clean export would misrepresent it. Tally error records as the stream arrives and raise a warning toast naming the count. Each chunk is decoded to scan its lines and then dropped, so only one chunk plus a partial line is ever live and the body is still retained as bytes -- decoding the whole payload is what previously ran the tab out of memory. Detection prefilters on a substring and parses only candidates, since these records nest deeply and parsing every one of a large stream is slow.
bencap
force-pushed
the
chore/bencap/export-hardening
branch
from
August 12, 2026 18:39
07b14c6 to
9d0eba7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UI support to leverage VariantEffect/mavedb-api#838.
The API now reports a variant it cannot annotate as a record carrying an error object instead of letting the exception truncate the body. A download containing those records is complete and worth saving, but treating it as a clean export would misrepresent it.
Tally error records as the stream arrives and raise a warning toast naming the count. Each chunk is decoded to scan its lines and then dropped, so only one chunk plus a partial line is ever live and the body is still retained as bytes. Detection prefilters on a substring and parses only candidates, since these records nest deeply and parsing every one of a large stream is slow.