feat(variant): show gnomAD population frequency on the variant page - #710
Merged
bencap merged 2 commits intoAug 12, 2026
Conversation
bencap
force-pushed
the
feature/bencap/447/gnomad-allele-frequency
branch
from
August 11, 2026 00:04
e9d93a7 to
38894c6
Compare
bencap
force-pushed
the
feature/bencap/447/gnomad-allele-frequency
branch
from
August 11, 2026 16:27
3bfb73b to
7ffaa12
Compare
Fills the annotations card's "Population Frequency" column, until now a "Data coming soon" placeholder. gnomAD is linked to a single mapped variant by ClinGen allele ID, so the frequency is a direct assertion about the measured allele rather than an aggregate over related variants. - Add MvGnomadSummary: AF with the AC/AN behind it, FAF95 with the genetic ancestry group attaining it, and a deep link to the gnomAD variant page, bottom-aligned so provenance lines up across the card's columns. - Read the record from the score set's variant data CSV via gnomadFromVariantRow, which normalises the namespace's NA sentinels. A variant absent from gnomAD reports as having no record, not zero frequency. - Derive GnomadFrequency from the generated OpenAPI schema, so renaming or retyping a field on the API model breaks compilation here. - Split HISTOGRAM_VARIANT_DATA_NAMESPACES into SCORE_SET_CHART_NAMESPACES and VARIANT_PAGE_NAMESPACES. One list fed two screens under a name describing neither, and only the variant page reads gnomAD, so the score set charts no longer fetch seven unused columns on every row. Requires the widened gnomad CSV namespace in the API.
bencap
force-pushed
the
feature/bencap/447/gnomad-allele-frequency
branch
from
August 12, 2026 18:39
7ffaa12 to
36c43e5
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fills the annotations card's "Population Frequency" column, until now a "Data coming soon" placeholder. gnomAD is linked to a single mapped variant by ClinGen allele ID, so the frequency is a direct assertion about the measured allele rather than an aggregate over related variants.
Requires the widened gnomad CSV namespace in the API, see VariantEffect/mavedb-api#836.