Repository navigation
Regenerate API and remove Tavus support - #196
Merged
Merged
Conversation
Tavus was removed from Vapi, so its no longer in the API, which broke type checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: VAPICS-1747, PRISM-2325
Problem
CI on
mainfails right now, and so does CI on every PR.ci.ymlregeneratesapi.tsfrom the live prod spec before it builds. The backend has since removed the disabled Tavus voice provider from the API, so'tavus'is no longer a validvoice.providervalue and the twoisVideoEnabledchecks invapi.tsno longer compile:Fix
api.tsfrom the current prod spec. It also addsCreateWebCallDTO.videoRecordingStartMode, which Add support for videoRecordingStartMode #193 depends on.isVideoEnabledcheck. It subscribed to the assistant participant's video track when the voice was a Tavus avatar. The API can no longer return that provider, so the check was alwaysfalse:subscribeToTracksnow subscribes to remote video only when video recording is enabled, the same behavior as before.daily-call-object-creationcall-start-progressevent no longer includesisVideoEnabledin itsmetadata. This is the only change that consumers can see.No version bump. The release goes out through the Update Dependencies and API workflow after #193 merges.
Verification
tsc --noEmitis clean.npm testpasses 73/73.isVideoEnabledortavusreferences remain invapi.ts.