Skip to content

Validate Model Target JSON responses #3222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adamtheturtle merged 1 commit into from
Sep 10, 2026
Merged

Validate Model Target JSON responses #3222

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions src/vws/_model_targets.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@

from beartype import BeartypeConf, beartype

from vws._json_utils import JSONValue, json_object
from vws.exceptions.custom_exceptions import ServerError
from vws.exceptions.model_target_exceptions import (
ModelTargetAuthenticationError,
Expand All @@ -25,10 +26,7 @@
from vws.reports import ModelTargetDatasetStatusReport
from vws.response import Response

type _JSONValue = (
bool | int | float | str | list[_JSONValue] | dict[str, _JSONValue] | None
)
type _JSONObject = dict[str, _JSONValue]
type _JSONObject = dict[str, JSONValue]

OAUTH2_ENDPOINT_PATH = "/oauth2/token"
OAUTH2_TOKEN_BODY = b"grant_type=client_credentials"
Expand Down Expand Up @@ -87,7 +85,7 @@ def access_token_from_response(*, response: Response) -> tuple[str, float]:
if response.status_code != HTTPStatus.OK:
raise ModelTargetOAuth2Error(response=response)

response_data = dict[str, object](json.loads(s=response.text))
response_data = json_object(value=response.text)
access_token = response_data.get("access_token")
expires_in = response_data.get("expires_in")
if not isinstance(access_token, str) or not isinstance(
Expand Down Expand Up @@ -190,7 +188,7 @@ def _view_dict(*, view: ModelTargetView) -> _JSONObject:
},
}
if view.states is not None:
states = list[_JSONValue](view.states)
states = list[JSONValue](view.states)
view_dict["states"] = states

return view_dict
Expand Down Expand Up @@ -308,7 +306,7 @@ def dataset_uuid_from_response(*, response: Response) -> str:
Returns:
The UUID of the created dataset.
"""
response_data = dict(json.loads(s=response.text))
response_data = json_object(value=response.text)
return str(object=response_data["uuid"])


Expand All @@ -325,7 +323,7 @@ def status_report_from_response(
Returns:
The status of the dataset.
"""
response_data = dict(json.loads(s=response.text))
response_data = json_object(value=response.text)
return ModelTargetDatasetStatusReport.from_response_dict(
response_dict=response_data,
)