Validate JSON response shapes - #3212
Merged
Merged
Conversation
adamtheturtle
force-pushed
the
validate-json-response-shapes
branch
from
September 8, 2026 20:38
9ec08cb to
3c0fcad
Compare
adamtheturtle
force-pushed
the
validate-json-response-shapes
branch
from
September 8, 2026 20:44
a89f66f to
a15e8c2
Compare
adamtheturtle
force-pushed
the
validate-json-response-shapes
branch
from
September 8, 2026 20:48
a15e8c2 to
17e32e1
Compare
adamtheturtle
force-pushed
the
validate-json-response-shapes
branch
from
September 8, 2026 21:05
17e32e1 to
8945fa5
Compare
adamtheturtle
force-pushed
the
validate-json-response-shapes
branch
from
September 8, 2026 21:47
8945fa5 to
82296d2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repeated JSON response parsing left values as unknown to the type checker, so callers suppressed 21 real boundary-type errors.
This adds one runtime-validated JSON boundary for objects, strings, string lists, and object lists, and routes the sync and async VWS, query, VuMark, and exception paths through it. Malformed response shapes now fail clearly instead of being trusted through inline ignores.
Malformed payload coverage exercises the public VWS and CloudRecoService clients only; there are no direct tests of the private JSON helpers.
Validation: