[k2] fix tl::Either variant access and modernize#1535
Merged
Conversation
Shamzik
reviewed
Feb 25, 2026
apolyakov
force-pushed
the
apolyakov/k2-fix-tl-either-store
branch
from
97e5d77 to
0482f07
Compare
PetrShumilov
requested changes
Feb 25, 2026
Shamzik
previously approved these changes
Feb 25, 2026
…traint * use std::get instead of static_cast for variant access * require std::default_initializable<T, U> for the class * modernize with if-with-initializer
apolyakov
dismissed stale reviews from KPHP-CI, Shamzik, and PetrShumilov
via
700b7e2
apolyakov
force-pushed
the
apolyakov/k2-fix-tl-either-store
branch
from
0482f07 to
700b7e2
Compare
Shamzik
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.