Open
Conversation
- don't close write end of the pipe to prevent infinite hanging in the event loop - send next batch of run once messages only if we don't have running php scripts
PetrShumilov
requested changes
Feb 27, 2026
| assert(write(write_fd, q, (size_t)qsize) == qsize); | ||
| } | ||
| if (run_once_mode_enabled) { | ||
| run_once_invoker.init(run_once_count); |
Contributor
There was a problem hiding this comment.
Are you sure that worker wouldn't be started "in both modes simultaneously"? For example, if I pass ports option and once
Contributor
Author
There was a problem hiding this comment.
added extra check that it never happens
| epoll_insert_pipe(pipe_for_read, read_fd, &ct_php_rpc_client, &rpc_client_methods); | ||
| } | ||
|
|
||
| bool PhpScriptRunOnceInvoker::invoke_run_once(int runs_count) { |
Contributor
There was a problem hiding this comment.
nit: add assert(runs_count > 0) here
Contributor
Author
There was a problem hiding this comment.
actually it works correct with zero
| } | ||
|
|
||
| rpc_client_methods.rpc_ready = nullptr; | ||
| epoll_insert_pipe(pipe_for_read, read_fd, &ct_php_rpc_client, &rpc_client_methods); |
Contributor
There was a problem hiding this comment.
As I see, will be better to check the result of epoll_insert_pipe too
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main changes:
PhpScriptRunOnceInvokerBefore these changes execution suspended infinitely with
--oncecount more than 2720, caused by blocking writing to pipe when its buffer was overflowed.