Skip to content

[k2] revert "[k2] replace tl::is_int32_overflow with std::in_range (#…#1530

Merged
apolyakov merged 1 commit intomasterfrom
apolyakov/k2/revert-01a7aa616ec933ece88a17b91c79e6828596628b
Feb 18, 2026
Merged

[k2] revert "[k2] replace tl::is_int32_overflow with std::in_range (#…#1530
apolyakov merged 1 commit intomasterfrom
apolyakov/k2/revert-01a7aa616ec933ece88a17b91c79e6828596628b

Conversation

@apolyakov
Copy link
Contributor

…1527)"

It turns out it's intentional that the code didn't use standard algorithms here. The reason for that is that it doesn't matter for TL whether tl::int is signed or unsigned

This reverts commit 01a7aa6.

…1527)"

It turns out it's intentional that the code didn't use standard
algorithms here. The reason for that is that it doesn't matter for
TL whether tl::int is signed or unsigned

This reverts commit 01a7aa6.
@apolyakov apolyakov added this to the next milestone Feb 18, 2026
@apolyakov apolyakov self-assigned this Feb 18, 2026
@apolyakov apolyakov added bug Something isn't working k2 k2 related labels Feb 18, 2026
Copy link
Contributor

@PetrShumilov PetrShumilov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@apolyakov apolyakov merged commit 5aa00a1 into master Feb 18, 2026
7 checks passed
@apolyakov apolyakov deleted the apolyakov/k2/revert-01a7aa616ec933ece88a17b91c79e6828596628b branch February 18, 2026 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working k2 k2 related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants