Fix broad toolkit approve policies being dropped as legacy connection records - #1550
Open
sethcarlton wants to merge 3 commits into
Open
Fix broad toolkit approve policies being dropped as legacy connection records#1550sethcarlton wants to merge 3 commits into
sethcarlton wants to merge 3 commits into
Conversation
A broad approve rule was mistaken for a legacy connection record when it covered a narrower persisted connection. Runtime then prompted for destructive tools even though the toolkit UI showed Always run. Keep matching broad policies active and cover both dynamic invocation and the toolkit MCP surface.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Write tools in toolkits can prompt for approval even when they are set to “Always run.” This occurs when a broad approve policy covers a narrower connection or tool ID:
Although the UI shows “Always run,” the server-side resolver mistakes the policy for a legacy connection row because it does not exactly match the saved connection pattern. The resolver drops the policy and uses the plugin default,
require_approval.Fix
Treat a policy as a legacy connection row only when its pattern covers no saved connection. This keeps broad approve policies active when they cover narrower connections or tool IDs.
Testing
packages/plugins/toolkits/src/server.test.ts.format:check,lint,typecheck, andtestpass.