[codex] resolve modal accessibility warnings#2
Draft
UnixSafe wants to merge 1 commit into
Draft
Conversation
UnixSafe
force-pushed
the
codex/fix-a11y-overlays
branch
from
1025950 to
f506184
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changement
<div onclick>par des boutons plein écran accessibles.aria-modal, labels et titres de dialogue quand nécessaire.autofocusdu lock screen signalé par Svelte.Pourquoi
Le build passait, mais
svelte-checket Vite signalaient 17 warnings d'accessibilité sur les overlays, modales et panneaux mobiles. Ces warnings masquaient de vrais problèmes de sémantique interactive.Validation
npm run check: 0 erreur, 0 warning.npm run build: OK, sans warning Svelte.npx vitest run: 90 tests OK surorigin/master.