Skip to content

Fix windows compile warnings#451

Open
urrsk wants to merge 1 commit intoUniversalRobots:masterfrom
urrsk:fixwindowswarnings
Open

Fix windows compile warnings#451
urrsk wants to merge 1 commit intoUniversalRobots:masterfrom
urrsk:fixwindowswarnings

Conversation

@urrsk
Copy link
Member

@urrsk urrsk commented Mar 2, 2026

Fix windows compile warnings and from now all warning is treat as errors

@codecov
Copy link

codecov bot commented Mar 2, 2026

Codecov Report

❌ Patch coverage is 65.33333% with 26 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.31%. Comparing base (59db585) to head (f33bed4).

Files with missing lines Patch % Lines
src/ur/dashboard_client_implementation_x.cpp 30.00% 14 Missing ⚠️
src/ur/ur_driver.cpp 0.00% 3 Missing ⚠️
include/ur_client_library/primary/primary_parser.h 60.00% 2 Missing ⚠️
src/rtde/rtde_client.cpp 50.00% 2 Missing ⚠️
include/ur_client_library/comm/pipeline.h 66.66% 1 Missing ⚠️
...lient_library/ur/dashboard_client_implementation.h 0.00% 1 Missing ⚠️
src/comm/tcp_server.cpp 75.00% 1 Missing ⚠️
src/control/reverse_interface.cpp 80.00% 1 Missing ⚠️
src/ur/dashboard_client.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #451      +/-   ##
==========================================
+ Coverage   76.28%   76.31%   +0.03%     
==========================================
  Files         105      105              
  Lines        5537     5536       -1     
  Branches      593      593              
==========================================
+ Hits         4224     4225       +1     
+ Misses       1015     1012       -3     
- Partials      298      299       +1     
Flag Coverage Δ
start_ursim 83.51% <ø> (-0.85%) ⬇️
ur20-latest 68.80% <55.40%> (+0.06%) ⬆️
ur5-3.14.3 71.76% <56.00%> (ø)
ur5e-10.11.0 64.86% <52.70%> (-0.20%) ⬇️
ur5e-10.12.0 65.87% <59.45%> (-0.27%) ⬇️
ur5e-10.7.0 64.07% <50.00%> (-0.04%) ⬇️
ur5e-5.9.4 72.43% <56.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@urrsk urrsk force-pushed the fixwindowswarnings branch 6 times, most recently from 1ac5fef to 86214fb Compare March 3, 2026 07:41
From now all warning is treat as errors
@urrsk urrsk force-pushed the fixwindowswarnings branch from 86214fb to f33bed4 Compare March 3, 2026 07:53
@urrsk urrsk marked this pull request as ready for review March 3, 2026 08:21
@urrsk
Copy link
Member Author

urrsk commented Mar 3, 2026

bugbot

@urrsk urrsk requested a review from urfeex March 3, 2026 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant