refactor: remove Linq from the CLI query layer and its tests (MTT-16534)

- Loops and List/Array methods (Find, FindAll, Exists, ConvertAll, GetRange) replace every Linq call in Editor/CliQueries and Tests/Editor/Cli.
- New helpers keep the output unchanged: StableSort keeps OrderBy's tie order for managers, spawned objects and stats messages. WithoutDuplicates keeps Distinct's first-seen order. JoinNames builds the comma-separated lists in messages.
- Session's IsConnected and CountOtherClients replace the hidden Linq Contains and Count on ConnectedClientsIds.

Author: jy-vivox

com.unity.netcode.gameobjects/Editor/CliQueries/NgoCliQueries.Authoring.cs

@@ -1,7 +1,6 @@
 using System;
 using System.Collections.Generic;
 using System.IO;
-using System.Linq;
 using System.Text.RegularExpressions;
 using Unity.Netcode.GameObjects.Editor.Configuration;
 using Unity.Netcode.Transports.UTP;
@@ -38,7 +37,7 @@ internal static CreateNetworkManagerResult CreateNetworkManager(string name, Net
             var existing = FindManagers();
             if (existing.Count > 0)
             {
-                throw new InvalidOperationException($"The open scenes already have a NetworkManager ({string.Join(", ", existing.Select(m => $"{GetHierarchyPath(m.transform)} in {SceneLabel(m.gameObject.scene)}"))}). A session uses one; inspect it with netcode.gameobjects.config get.");
+                throw new InvalidOperationException($"The open scenes already have a NetworkManager ({JoinNames(existing, m => $"{GetHierarchyPath(m.transform)} in {SceneLabel(m.gameObject.scene)}")}). A session uses one; inspect it with netcode.gameobjects.config get.");
             }
 
             var scene = SceneManager.GetActiveScene();
@@ -83,7 +82,7 @@ internal static CreateNetworkManagerResult CreateNetworkManager(string name, Net
             EditorSceneManager.MarkSceneDirty(scene);
 
             result.Created = true;
-            result.PrefabsLists = manager.NetworkConfig.Prefabs.NetworkPrefabsLists.Where(l => l != null).Select(AssetDatabase.GetAssetPath).ToList();
+            result.PrefabsLists = PrefabsListPaths(manager.NetworkConfig.Prefabs.NetworkPrefabsLists);
             if (result.PrefabsLists.Count == 0)
             {
                 result.Notes.Add("No network prefabs list attached (default prefab generation is off). Register prefabs with netcode.gameobjects register_prefab.");
@@ -126,7 +125,7 @@ internal static PrefabListResult ListPrefabs(string listFilter)
                     Manager = GetHierarchyPath(manager.transform),
                     Scene = manager.gameObject.scene.name,
                     PlayerPrefab = config?.PlayerPrefab != null ? AssetPathOrName(config.PlayerPrefab) : null,
-                    Lists = config?.Prefabs?.NetworkPrefabsLists.Where(l => l != null).Select(AssetDatabase.GetAssetPath).ToList() ?? new List<string>(),
+                    Lists = config?.Prefabs != null ? PrefabsListPaths(config.Prefabs.NetworkPrefabsLists) : new List<string>(),
                 });
             }
             return result;
@@ -260,7 +259,7 @@ internal static RegisterPrefabResult RegisterPrefab(string prefab, string listPa
             }
 
             var result = new RegisterPrefabResult { DryRun = dryRun, Prefab = prefabPath };
-            var registeredIn = FindPrefabsLists().Where(l => IsRegisteredIn(l, prefabAsset)).Select(AssetDatabase.GetAssetPath).ToList();
+            var registeredIn = PrefabsListPaths(FindPrefabsLists().FindAll(l => IsRegisteredIn(l, prefabAsset)));
             var list = ResolveTargetList(listPath, dryRun, result.Notes);
             result.List = list != null ? AssetDatabase.GetAssetPath(list) : NetworkPrefabProcessor.DefaultNetworkPrefabsPath;
 
@@ -298,18 +297,29 @@ private static NetworkPrefabsList ResolveTargetList(string listPath, bool dryRun
                 return list;
             }
 
-            var managerLists = FindManagers()
-                .SelectMany(m => m.NetworkConfig?.Prefabs?.NetworkPrefabsLists ?? new List<NetworkPrefabsList>())
-                .Where(l => l != null)
-                .Distinct()
-                .ToList();
+            var managerLists = new List<NetworkPrefabsList>();
+            foreach (var manager in FindManagers())
+            {
+                var lists = manager.NetworkConfig?.Prefabs?.NetworkPrefabsLists;
+                if (lists == null)
+                {
+                    continue;
+                }
+                foreach (var list in lists)
+                {
+                    if (list != null && !managerLists.Contains(list))
+                    {
+                        managerLists.Add(list);
+                    }
+                }
+            }
             if (managerLists.Count == 1)
             {
                 return managerLists[0];
             }
             if (managerLists.Count > 1)
             {
-                throw new ArgumentException($"The scene's NetworkManagers use several lists. Pass list with one of: {string.Join(", ", managerLists.Select(AssetDatabase.GetAssetPath))}.");
+                throw new ArgumentException($"The scene's NetworkManagers use several lists. Pass list with one of: {JoinNames(managerLists, AssetDatabase.GetAssetPath)}.");
             }
 
             var defaultPath = NetworkPrefabProcessor.DefaultNetworkPrefabsPath;
@@ -341,7 +351,8 @@ internal static MakePrefabResult MakePrefab(string prefab, bool dryRun)
             {
                 result.AlreadyNetworkObject = true;
                 result.PrefabIdHash = existing.GlobalObjectIdHash;
-                result.RegisteredIn = FindPrefabsLists().Where(l => IsRegisteredIn(l, prefabAsset)).Select(AssetDatabase.GetAssetPath).FirstOrDefault();
+                var registeredIn = FindPrefabsLists().Find(l => IsRegisteredIn(l, prefabAsset));
+                result.RegisteredIn = registeredIn != null ? AssetDatabase.GetAssetPath(registeredIn) : null;
                 return result;
             }
             if (prefabAsset.GetComponentInChildren<NetworkManager>(true) != null)
@@ -375,7 +386,8 @@ internal static MakePrefabResult MakePrefab(string prefab, bool dryRun)
             {
                 result.Notes.Add("The prefab id hash is generated on the next import; check it with netcode.gameobjects list_prefabs.");
             }
-            result.RegisteredIn = FindPrefabsLists().Where(l => IsRegisteredIn(l, reloaded)).Select(AssetDatabase.GetAssetPath).FirstOrDefault();
+            var registeredList = FindPrefabsLists().Find(l => IsRegisteredIn(l, reloaded));
+            result.RegisteredIn = registeredList != null ? AssetDatabase.GetAssetPath(registeredList) : null;
             if (result.RegisteredIn == null)
             {
                 result.Notes.Add("Not in a network prefabs list yet. Register it with netcode.gameobjects register_prefab.");
@@ -446,7 +458,7 @@ internal static ProjectAuditResult Audit(string scope, string folder, int limit,
             {
                 result.Truncated = true;
             }
-            result.Issues = issues.Take(limit).ToList();
+            result.Issues = issues.GetRange(0, Math.Min(limit, issues.Count));
             return result;
         }
 
@@ -470,7 +482,15 @@ internal static AuditResult AuditPrefabs(string folder, int limit)
             var result = new AuditResult();
             var lists = FindPrefabsLists();
             // NetworkManager registers its player prefab when it starts, list or not.
-            var playerPrefabs = new HashSet<GameObject>(FindManagers().Select(m => m.NetworkConfig?.PlayerPrefab).Where(p => p != null));
+            var playerPrefabs = new HashSet<GameObject>();
+            foreach (var manager in FindManagers())
+            {
+                var playerPrefab = manager.NetworkConfig?.PlayerPrefab;
+                if (playerPrefab != null)
+                {
+                    playerPrefabs.Add(playerPrefab);
+                }
+            }
             var autoGenerate = NetcodeForGameObjectsProjectSettings.instance.GenerateDefaultNetworkPrefabs;
             var hashes = new Dictionary<uint, string>();
             var scriptCache = new Dictionary<string, bool>();
@@ -496,7 +516,7 @@ void Add(string severity, string code, string asset, string message)
             }
 
             var searchIn = string.IsNullOrWhiteSpace(folder) ? new[] { "Assets" } : new[] { folder.Trim() };
-            foreach (var path in AssetDatabase.FindAssets("t:Prefab", searchIn).Select(AssetDatabase.GUIDToAssetPath).Distinct())
+            foreach (var path in AssetPaths(AssetDatabase.FindAssets("t:Prefab", searchIn)))
             {
                 if (!UsesNetcodeScripts(path, scriptCache))
                 {
@@ -579,7 +599,7 @@ private static void AuditPrefab(GameObject prefabAsset, string path, List<Networ
                 hashes[hash] = path;
             }
 
-            if (!autoGenerate && !playerPrefabs.Contains(prefabAsset) && !lists.Any(l => IsRegisteredIn(l, prefabAsset)))
+            if (!autoGenerate && !playerPrefabs.Contains(prefabAsset) && !lists.Exists(l => IsRegisteredIn(l, prefabAsset)))
             {
                 add("warning", "NOT_REGISTERED", path, "Not in any network prefabs list, so it can't be spawned. Register it with netcode.gameobjects register_prefab.");
             }
@@ -613,12 +633,41 @@ private static bool UsesNetcodeScripts(string prefabPath, Dictionary<string, boo
 
         internal static List<NetworkPrefabsList> FindPrefabsLists()
         {
-            return AssetDatabase.FindAssets($"t:{nameof(NetworkPrefabsList)}")
-                .Select(AssetDatabase.GUIDToAssetPath)
-                .Distinct()
-                .Select(AssetDatabase.LoadAssetAtPath<NetworkPrefabsList>)
-                .Where(l => l != null)
-                .ToList();
+            var lists = new List<NetworkPrefabsList>();
+            foreach (var path in AssetPaths(AssetDatabase.FindAssets($"t:{nameof(NetworkPrefabsList)}")))
+            {
+                var list = AssetDatabase.LoadAssetAtPath<NetworkPrefabsList>(path);
+                if (list != null)
+                {
+                    lists.Add(list);
+                }
+            }
+            return lists;
+        }
+
+        /// <summary>The asset paths of found GUIDs, each once, in the order found.</summary>
+        private static List<string> AssetPaths(string[] guids)
+        {
+            var paths = new List<string>(guids.Length);
+            foreach (var guid in guids)
+            {
+                paths.Add(AssetDatabase.GUIDToAssetPath(guid));
+            }
+            return WithoutDuplicates(paths);
+        }
+
+        /// <summary>The asset paths of the prefabs lists that are set, skipping empty entries.</summary>
+        internal static List<string> PrefabsListPaths(List<NetworkPrefabsList> lists)
+        {
+            var paths = new List<string>();
+            foreach (var list in lists)
+            {
+                if (list != null)
+                {
+                    paths.Add(AssetDatabase.GetAssetPath(list));
+                }
+            }
+            return paths;
         }
 
         /// <summary>Resolves a prefab path, GUID or name to the prefab asset.</summary>
@@ -641,16 +690,13 @@ internal static GameObject ResolvePrefab(string prefab)
             }
             else
             {
-                var matches = AssetDatabase.FindAssets($"{prefab} t:Prefab")
-                    .Select(AssetDatabase.GUIDToAssetPath)
-                    .Where(p => string.Equals(Path.GetFileNameWithoutExtension(p), prefab, StringComparison.OrdinalIgnoreCase))
-                    .Distinct()
-                    .ToList();
+                var matches = AssetPaths(AssetDatabase.FindAssets($"{prefab} t:Prefab"))
+                    .FindAll(p => string.Equals(Path.GetFileNameWithoutExtension(p), prefab, StringComparison.OrdinalIgnoreCase));
                 if (matches.Count > 1)
                 {
                     throw new ArgumentException($"Several prefabs are named '{prefab}': {string.Join(", ", matches)}. Pass the path instead.");
                 }
-                path = matches.FirstOrDefault();
+                path = matches.Count > 0 ? matches[0] : null;
             }
 
             var asset = (string.IsNullOrEmpty(path) ? null : AssetDatabase.LoadAssetAtPath<GameObject>(path)) ?? throw new ArgumentException($"No prefab found for '{prefab}'. Search with asset find, or list network prefabs with netcode.gameobjects list_prefabs.");

com.unity.netcode.gameobjects/Editor/CliQueries/NgoCliQueries.Config.cs

@@ -1,7 +1,6 @@
 using System;
 using System.Collections.Generic;
 using System.Globalization;
-using System.Linq;
 using System.Reflection;
 using Unity.Netcode.GameObjects.Editor.Configuration;
 using Unity.Netcode.Transports.UTP;
@@ -33,7 +32,7 @@ internal static ConfigResult GetConfig(string managerFilter)
                 Transport = DescribeTransport(config.NetworkTransport),
                 LogLevel = manager.LogLevel.ToString(),
                 PlayerPrefab = config.PlayerPrefab != null ? AssetPathOrName(config.PlayerPrefab) : null,
-                PrefabsLists = config.Prefabs?.NetworkPrefabsLists.Where(l => l != null).Select(AssetDatabase.GetAssetPath).ToList() ?? new List<string>(),
+                PrefabsLists = config.Prefabs != null ? PrefabsListPaths(config.Prefabs.NetworkPrefabsLists) : new List<string>(),
                 GenerateDefaultNetworkPrefabs = NetcodeForGameObjectsProjectSettings.instance.GenerateDefaultNetworkPrefabs,
                 DefaultNetworkPrefabsPath = NetworkPrefabProcessor.DefaultNetworkPrefabsPath,
             };
@@ -42,9 +41,8 @@ internal static ConfigResult GetConfig(string managerFilter)
                 var value = field.GetValue(config);
                 result.NetworkConfig[ToSnakeCase(field.Name)] = value is Enum ? value.ToString() : value;
             }
-            result.SettableFields = SettableConfigFields().Select(f => ToSnakeCase(f.Name))
-                .Concat(new[] { k_Address, k_Port, k_ListenAddress, k_PlayerPrefab, k_LogLevel })
-                .ToList();
+            result.SettableFields = SettableConfigFields().ConvertAll(f => ToSnakeCase(f.Name));
+            result.SettableFields.AddRange(new[] { k_Address, k_Port, k_ListenAddress, k_PlayerPrefab, k_LogLevel });
             return result;
         }
 
@@ -163,7 +161,7 @@ internal static ConfigSetResult SetConfig(string field, string value, string man
                     }
                 default:
                     {
-                        var configField = SettableConfigFields().FirstOrDefault(f => ToSnakeCase(f.Name) == name) ?? throw new ArgumentException($"Unknown field '{field}'. Settable: {string.Join(", ", GetConfig(managerFilter).SettableFields)}.");
+                        var configField = SettableConfigFields().Find(f => ToSnakeCase(f.Name) == name) ?? throw new ArgumentException($"Unknown field '{field}'. Settable: {string.Join(", ", GetConfig(managerFilter).SettableFields)}.");
                         var parsed = ParseValue(configField.FieldType, value, name);
                         ValidateConfigValue(configField.Name, name, parsed, result.Notes);
                         target = manager;
@@ -295,7 +293,7 @@ private static void ValidateManager(NetworkManager manager, Action<string, strin
             // The dialog opens on entering play mode; in play mode the manager has moved to DontDestroyOnLoad.
             var scene = manager.gameObject.scene;
             var checkScene = config.EnableSceneManagement && !EditorApplication.isPlaying;
-            if (checkScene && !string.IsNullOrEmpty(scene.path) && !EditorBuildSettings.scenes.Any(s => s.enabled && s.path == scene.path))
+            if (checkScene && !string.IsNullOrEmpty(scene.path) && !Array.Exists(EditorBuildSettings.scenes, s => s.enabled && s.path == scene.path))
             {
                 add("warning", "SCENE_NOT_IN_BUILD", where, $"Scene management is on and {scene.path} isn't in the build's scene list, so clients can't load it. Entering play mode opens a dialog asking to add it; add it first with scene add_to_build, or turn scene management off (netcode.gameobjects.config set enable_scene_management false).");
             }
@@ -309,8 +307,8 @@ private static void ValidateManager(NetworkManager manager, Action<string, strin
                 add("error", "TICK_RATE_ZERO", where, "tick_rate is 0. Set it with netcode.gameobjects.config set tick_rate 30.");
             }
 
-            var lists = config.Prefabs?.NetworkPrefabsLists.Where(l => l != null).ToList() ?? new List<NetworkPrefabsList>();
-            if (config.Prefabs != null && config.Prefabs.NetworkPrefabsLists.Any(l => l == null))
+            var lists = config.Prefabs != null ? config.Prefabs.NetworkPrefabsLists.FindAll(l => l != null) : new List<NetworkPrefabsList>();
+            if (config.Prefabs != null && config.Prefabs.NetworkPrefabsLists.Exists(l => l == null))
             {
                 add("error", "MISSING_PREFABS_LIST", where, "A Network Prefabs Lists entry is empty or points to a deleted asset.");
             }
@@ -369,7 +367,7 @@ void Add(UnityEngine.GameObject prefab)
         private static void ValidateHybrid(NetworkConfig config, List<UnityEngine.GameObject> hybrid, string where, Action<string, string, string, string> add)
         {
 #if UNIFIED_NETCODE
-            var names = string.Join(", ", hybrid.Take(5).Select(AssetPathOrName));
+            var names = JoinNames(hybrid.GetRange(0, Math.Min(5, hybrid.Count)), AssetPathOrName);
             if (config.NetworkTopology == NetworkTopologyTypes.DistributedAuthority)
             {
                 add("error", "HYBRID_WITH_DISTRIBUTED_AUTHORITY", where, $"{NetworkPrefabs.DistributedAuthorityHybridPrefabError} Hybrid prefabs: {names}.");
@@ -394,23 +392,28 @@ private static NetcodeConfig FindNetcodeConfig()
             {
                 return NetcodeConfig.Global;
             }
-            var configs = AssetDatabase.FindAssets($"t:{nameof(NetcodeConfig)}")
-                .Select(AssetDatabase.GUIDToAssetPath)
-                .Select(AssetDatabase.LoadAssetAtPath<NetcodeConfig>)
-                .Where(c => c != null)
-                .ToList();
             // A project has one NetcodeConfig (Netcode for Entities reports several as an error).
-            return configs.FirstOrDefault();
+            foreach (var guid in AssetDatabase.FindAssets($"t:{nameof(NetcodeConfig)}"))
+            {
+                var config = AssetDatabase.LoadAssetAtPath<NetcodeConfig>(AssetDatabase.GUIDToAssetPath(guid));
+                if (config != null)
+                {
+                    return config;
+                }
+            }
+            return null;
         }
 #endif
 
         // --- Helpers ---
 
-        private static IEnumerable<FieldInfo> SettableConfigFields()
+        private static List<FieldInfo> SettableConfigFields()
         {
-            return typeof(NetworkConfig).GetFields(BindingFlags.Instance | BindingFlags.Public)
-                .Where(f => !f.IsInitOnly && (f.FieldType.IsPrimitive || f.FieldType.IsEnum))
-                .OrderBy(f => f.MetadataToken);
+            var fields = new List<FieldInfo>(typeof(NetworkConfig).GetFields(BindingFlags.Instance | BindingFlags.Public));
+            fields.RemoveAll(f => f.IsInitOnly || !(f.FieldType.IsPrimitive || f.FieldType.IsEnum));
+            // Declaration order; each field's metadata token is unique.
+            fields.Sort((a, b) => a.MetadataToken.CompareTo(b.MetadataToken));
+            return fields;
         }
 
         private static object ParseValue(Type type, string value, string name)
@@ -420,7 +423,7 @@ private static object ParseValue(Type type, string value, string name)
             {
                 if (type.IsEnum)
                 {
-                    var match = Enum.GetNames(type).FirstOrDefault(n => string.Equals(n, text, StringComparison.OrdinalIgnoreCase)) ?? throw new FormatException();
+                    var match = Array.Find(Enum.GetNames(type), n => string.Equals(n, text, StringComparison.OrdinalIgnoreCase)) ?? throw new FormatException();
                     return Enum.Parse(type, match);
                 }
                 if (type == typeof(bool))