fallback for truncated ListObjects V1 responses without NextMarker#1584
Draft
387809109 wants to merge 1 commit into
Draft
fallback for truncated ListObjects V1 responses without NextMarker#1584387809109 wants to merge 1 commit into
387809109 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
For non-AWS endpoints, netCDF-Java 5.9.1 selected ListObjects V1.
The original pagination logic was:
A direct AWS SDK ListObjects V1 request for Swift returned:
The page was valid and truncated, but Swift did not return NextMarker, therefore netCDF-Java repeatedly requested the first page.
changed that part to add a fallback for truncated ListObjects V1 responses without NextMarker
PR Checklist
until ready for review