Skip to content

Limit SLD parsing error information in message returned to user #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lesserwhirls merged 1 commit into from
Jul 10, 2026
Merged

Limit SLD parsing error information in message returned to user #29

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions wms/src/main/java/uk/ac/rdg/resc/edal/wms/GetMapStyleParams.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,8 @@

import org.apache.commons.io.IOUtils;

import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import uk.ac.rdg.resc.edal.domain.Extent;
import uk.ac.rdg.resc.edal.exceptions.EdalException;
import uk.ac.rdg.resc.edal.graphics.exceptions.EdalLayerNotFoundException;
Expand Down Expand Up @@ -80,6 +82,8 @@ public class GetMapStyleParams {
/* true if we are using an XML style specification */
private MapImage xmlMapImage = null;

private static final Logger log = LoggerFactory.getLogger(GetMapStyleParams.class);

/**
* Extract GetMap parameters from the URL, using a {@link WmsCatalogue} to
* determine default values.
Expand Down Expand Up @@ -138,8 +142,9 @@ public GetMapStyleParams(RequestParams params, WmsCatalogue catalogue) throws Ed
IOUtils.copy(is, writer);
xmlStyle = writer.toString();
} catch (IOException e) {
throw new EdalException(
"SLD argument specified, but SLD could not be read from URL: " + xmlLoc, e);
String partialMsg = "SLD argument specified, but SLD could not be read";
log.warn("{} from the URL: {}", partialMsg, xmlLoc, e);
throw new EdalException(partialMsg + ".");
}
} else {
/*
Expand Down
Loading