Skip to content

Harden SLD parsing #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lesserwhirls merged 1 commit into from
Jul 10, 2026
Merged

Harden SLD parsing #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions graphics/src/main/java/uk/ac/rdg/resc/edal/graphics/style/sld/StyleSLDParser.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,6 +271,8 @@ private static Document readXMLString(String xmlString) throws ParserConfigurati
SAXException, IOException, IllegalArgumentException {
DocumentBuilderFactory builderFactory = DocumentBuilderFactory.newInstance();
builderFactory.setNamespaceAware(true);
builderFactory.setXIncludeAware(false);
builderFactory.setFeature("http://apache.org/xml/features/disallow-doctype-decl", true);
// Uncomment to turn on schema validation
// builderFactory.setValidating(true);
try {
Expand Down
5 changes: 5 additions & 0 deletions wms/src/main/java/uk/ac/rdg/resc/edal/wms/GetMapStyleParams.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,11 @@ public GetMapStyleParams(RequestParams params, WmsCatalogue catalogue) throws Ed
URL url;
try {
url = new URL(xmlLoc);
String protocol = url.getProtocol();
if (!protocol.startsWith("http")) {
throw new EdalException(
"Reading SLD using protocol " + protocol + " is not supported");
}
InputStream is = url.openStream();
StringWriter writer = new StringWriter();
IOUtils.copy(is, writer);
Expand Down
Loading