Skip to content

Security: DNS modal ownership check + Forge deploy-command domain validation#1383

Open
vuckro wants to merge 1 commit into
Ultimate-Multisite:mainfrom
vuckro:security/dns-modal-ownership-and-forge-cmd
Open

Security: DNS modal ownership check + Forge deploy-command domain validation#1383
vuckro wants to merge 1 commit into
Ultimate-Multisite:mainfrom
vuckro:security/dns-modal-ownership-and-forge-cmd

Conversation

@vuckro

@vuckro vuckro commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Summary

Two small hardening fixes.

  • Domain_Mapping_Element::render_add_dns_record_modal() rendered the DNS
    record form for any domain_id with no ownership check, while its siblings
    (render_edit_dns_record_modal, handle_add_dns_record) all gate on
    customer_can_manage_dns(). Add the same gate so a customer cannot open the
    DNS form for a domain they don't own.
  • Laravel_Forge_Integration::get_deploy_command() interpolated the mapped
    domain into the custom deploy-command branch with no validation, while the
    sibling symlink branch validates the domain format. Apply the same
    hostname-format check before building the shell command.

…n validation

- Domain_Mapping_Element::render_add_dns_record_modal() rendered the DNS record
  form for any domain id with no ownership check, while its siblings
  (render_edit_dns_record_modal, handle_add_dns_record) all gate on
  customer_can_manage_dns(). Add the same gate so a customer cannot view the DNS
  form for a domain they don't own.
- Laravel_Forge_Integration::get_deploy_command() interpolated the mapped domain
  into the custom deploy command branch with no validation, while the symlink
  branch validates the domain format. Apply the same hostname-format check
  before building the command to prevent shell metacharacter injection.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@vuckro, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 29 minutes and 56 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: d16fc553-e8a3-4c84-9581-78773dc60d59

📥 Commits

Reviewing files that changed from the base of the PR and between 1310078 and e35f9ba.

📒 Files selected for processing (2)
  • inc/integrations/providers/laravel-forge/class-laravel-forge-integration.php
  • inc/ui/class-domain-mapping-element.php
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant