Security: DNS modal ownership check + Forge deploy-command domain validation#1383
Security: DNS modal ownership check + Forge deploy-command domain validation#1383vuckro wants to merge 1 commit into
Conversation
…n validation - Domain_Mapping_Element::render_add_dns_record_modal() rendered the DNS record form for any domain id with no ownership check, while its siblings (render_edit_dns_record_modal, handle_add_dns_record) all gate on customer_can_manage_dns(). Add the same gate so a customer cannot view the DNS form for a domain they don't own. - Laravel_Forge_Integration::get_deploy_command() interpolated the mapped domain into the custom deploy command branch with no validation, while the symlink branch validates the domain format. Apply the same hostname-format check before building the command to prevent shell metacharacter injection. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Warning Review limit reached
More reviews will be available in 29 minutes and 56 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Two small hardening fixes.
Domain_Mapping_Element::render_add_dns_record_modal()rendered the DNSrecord form for any
domain_idwith no ownership check, while its siblings(
render_edit_dns_record_modal,handle_add_dns_record) all gate oncustomer_can_manage_dns(). Add the same gate so a customer cannot open theDNS form for a domain they don't own.
Laravel_Forge_Integration::get_deploy_command()interpolated the mappeddomain into the custom deploy-command branch with no validation, while the
sibling symlink branch validates the domain format. Apply the same
hostname-format check before building the shell command.