Skip to content

Security: reject unsafe manifest plugin paths during site import #1379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vuckro wants to merge 1 commit into
base: main
Choose a base branch
from
+17 −0
Open

Security: reject unsafe manifest plugin paths during site import #1379

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions inc/site-exporter/mu-migration/includes/commands/class-mu-migration-import.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -599,6 +599,23 @@ private function move_and_activate_plugins($plugins_dir, $plugins, $blog_plugins
$installed_plugins = WP_PLUGIN_DIR;
$check_plugins = false !== $blog_plugins && false !== $network_plugins;
foreach ( $plugins as $plugin_name => $plugin ) {
/*
* $plugin_name comes from the imported site manifest (untrusted
* JSON). A plugin basename is "<folder>/<file>.php" or
* "<file>.php" — never absolute and never containing a
* parent-directory segment. Reject anything else so a crafted
* manifest cannot drive rename()/activate_plugin() to a path
* outside WP_PLUGIN_DIR (path traversal / arbitrary inclusion).
*/
if ( ! is_string($plugin_name) || '' === $plugin_name
|| false !== strpos($plugin_name, "\0")
|| 0 === strpos($plugin_name, '/')
|| 0 === strpos($plugin_name, '\\')
|| preg_match('#(^|[\\\\/])\.\.([\\\\/]|$)#', $plugin_name) ) {
WP_CLI::warning(sprintf(__('Skipping plugin with unsafe path: %s', 'mu-migration'), (string) $plugin_name));
continue;
}

$plugin_folder = dirname($plugin_name);
$fullPluginPath = $plugins_dir . '/' . $plugin_folder;

Expand Down
Loading