Skip to content

Security: escape customer/product output in the Broadcast list table #1373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vuckro wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −5
Open

Security: escape customer/product output in the Broadcast list table #1373

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions inc/list-tables/class-broadcast-list-table.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,11 +182,11 @@

$email = $customer->get_email_address();

$html = "<a href='{$customer_link}' class='wu-p-2 wu-flex wu-flex-grow wu-bg-gray-100 wu-rounded wu-items-center wu-border wu-border-solid wu-border-gray-300'>
$html = "<a href='" . esc_url($customer_link) . "' class='wu-p-2 wu-flex wu-flex-grow wu-bg-gray-100 wu-rounded wu-items-center wu-border wu-border-solid wu-border-gray-300'>
{$avatar}
<div class='wu-pl-2'>
<strong class='wu-block'>{$display_name} <small class='wu-font-normal'>(#{$id})</small></strong>
<small>{$email}</small>
<strong class='wu-block'>" . esc_html($display_name) . " <small class='wu-font-normal'>(#" . esc_html((string) $id) . ")</small></strong>

Check warning on line 188 in inc/list-tables/class-broadcast-list-table.php

View workflow job for this annotation

GitHub Actions / Code Quality Checks 

String ")</small></strong>\n												<small>" does not require double quotes; use single quotes instead
<small>" . esc_html($email) . "</small>

Check warning on line 189 in inc/list-tables/class-broadcast-list-table.php

View workflow job for this annotation

GitHub Actions / Code Quality Checks 

String "</small>\n										</div>\n								</a>" does not require double quotes; use single quotes instead
</div>
</a>";

Expand Down Expand Up @@ -215,7 +215,7 @@

$customer_link = wu_network_admin_url('wp-ultimo-edit-customer', $url_atts);

$html .= "<div class='wu-flex wu--mr-4'><a role='tooltip' aria-label='{$tooltip_name}' href='{$customer_link}'>{$avatar}</a></div>";
$html .= "<div class='wu-flex wu--mr-4'><a role='tooltip' aria-label='" . esc_attr($tooltip_name) . "' href='" . esc_url($customer_link) . "'>{$avatar}</a></div>";
}

if ($targets_count < 7) {
Expand Down Expand Up @@ -363,7 +363,7 @@
</div>';
}

$html .= "<div class='wu-flex wu--mr-4'><a role='tooltip' aria-label='{$product_name}' href='{$product_link}'>{$image}</a></div>";
$html .= "<div class='wu-flex wu--mr-4'><a role='tooltip' aria-label='" . esc_attr($product_name) . "' href='" . esc_url($product_link) . "'>{$image}</a></div>";
}

if ($product_count > 1 && $product_count < 5) {
Expand Down
Loading