Skip to content

Security: enforce payment ownership in the status-polling AJAX endpoint #1372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vuckro wants to merge 1 commit into
base: main
Choose a base branch
from
+16 −0
Open

Security: enforce payment ownership in the status-polling AJAX endpoint #1372

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions inc/managers/class-gateway-manager.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -637,6 +637,22 @@ public function ajax_check_payment_status(): void {
wp_send_json_error(['message' => __('Payment not found.', 'ultimate-multisite')]);
}

/*
* Enforce ownership. The payment hash is a reversible identifier (not a
* secret), and the polling nonce is a static value localised into every
* checkout/thank-you page, so neither binds the request to a payment.
* Without this check any logged-in user could poll the status of — and
* trigger gateway verification on — arbitrary payments. Only the owning
* customer (or a network admin) may proceed.
*/
$current_customer = wu_get_current_customer();

$is_owner = $current_customer && (int) $payment->get_customer_id() === (int) $current_customer->get_id();

if ( ! $is_owner && ! current_user_can('manage_network')) {
wp_send_json_error(['message' => __('Payment not found.', 'ultimate-multisite')]);
}

// If already completed, return success
if ($payment->get_status() === \WP_Ultimo\Database\Payments\Payment_Status::COMPLETED) {
wp_send_json_success(
Expand Down
Loading