Repository navigation
fix(eval): include agent final response in trajectory AgentRunHistory [FOR-1629] #1949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Chibionos
wants to merge
3
commits into
main
Choose a base branch
from
fix/trajectory-history-agent-output
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+357
−8
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,71 @@ | ||
| """Render a workload's final output for the trajectory judge prompts.""" | ||
|
|
||
| import json | ||
| from typing import Any | ||
|
|
||
| from pydantic import TypeAdapter, ValidationError | ||
|
|
||
| from uipath.core.chat import ( | ||
| UiPathConversationContentPartData, | ||
| UiPathConversationMessageData, | ||
| UiPathExternalValue, | ||
| ) | ||
|
|
||
| AGENT_RESPONSE_MESSAGES_KEY = "uipath__agent_response_messages" | ||
| FINAL_RESPONSE_HEADER = "Agent Final Response:" | ||
|
|
||
| _messages_adapter = TypeAdapter(list[UiPathConversationMessageData]) | ||
|
|
||
|
|
||
| def render_agent_output(output: Any) -> str: | ||
| if isinstance(output, str): | ||
| return output | ||
| if isinstance(output, dict) and AGENT_RESPONSE_MESSAGES_KEY in output: | ||
| rendered = _render_conversational_output(output) | ||
| if rendered: | ||
| return rendered | ||
| return _to_json(output) | ||
|
|
||
|
|
||
| def append_agent_output(history: str, output: Any) -> str: | ||
| if output is None: | ||
| return history | ||
| section = f"{FINAL_RESPONSE_HEADER}\n{render_agent_output(output)}" | ||
| return f"{history}\n\n{section}" if history else section | ||
|
|
||
|
|
||
| def _render_conversational_output(output: dict[str, Any]) -> str: | ||
| try: | ||
| messages = _messages_adapter.validate_python( | ||
| output[AGENT_RESPONSE_MESSAGES_KEY] | ||
| ) | ||
| except ValidationError: | ||
| return "" | ||
|
|
||
| # toolCalls are skipped: trace_to_str already renders the executed calls from spans. | ||
| lines = [ | ||
| f"[{message.role}] {rendered}" | ||
| for message in messages | ||
| for part in message.content_parts | ||
| if (rendered := _render_content_part(part)) | ||
| ] | ||
|
|
||
| structured_fields = { | ||
| k: v for k, v in output.items() if k != AGENT_RESPONSE_MESSAGES_KEY | ||
| } | ||
| if structured_fields: | ||
| lines.append(_to_json(structured_fields)) | ||
| return "\n".join(lines) | ||
|
|
||
|
|
||
| def _render_content_part(part: UiPathConversationContentPartData) -> str: | ||
| if isinstance(part.data, UiPathExternalValue): | ||
| return f"Attachment ({part.mime_type}): {part.data.uri}" | ||
| inline = part.data.inline | ||
| if inline is None or inline == "": | ||
| return "" | ||
| return inline if isinstance(inline, str) else _to_json(inline) | ||
|
|
||
|
|
||
| def _to_json(value: Any) -> str: | ||
| return json.dumps(value, indent=2, default=str) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P1 -- Performance:
_get_actual_outputcalled twice per evaluation, causing double attachment downloadThe base class
LLMJudgeMixin.evaluatecalls_get_actual_outputat two sites:_create_evaluation_promptevaluate()for the justification context dictBefore this PR,
_get_actual_outputwas pure computation (trace_to_str()). Now it callsdownload_attachment_as_string-- synchronous HTTP download + temp file write/read. Every trajectory evaluation with an attachment URI will download the file twice and block the event loop twice.Fix: Override
evaluate()inBaseLLMTrajectoryEvaluatorto call_get_actual_outputonce and pass the cached result, or use@functools.lru_cache.Not blocking since attachment-backed trajectory evals are uncommon, but worth a follow-up.