feat(apollo-react): BaseCanvas - add flag for toggling back navigation#314
Closed
david-rios-uipath wants to merge 1 commit intomainfrom
Closed
feat(apollo-react): BaseCanvas - add flag for toggling back navigation#314david-rios-uipath wants to merge 1 commit intomainfrom
david-rios-uipath wants to merge 1 commit intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
d718b29 to
0220995
Compare
Contributor
Author
|
Will be removing hook -- no flag needed (see #318) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why do we need this flag?
The
usePreventBackNavigationhook that's used inapollo-react/BaseCanvasprevents horizontal 'wheel' scroll events globally (source). It's intended to prevent accidental back navigation via gesture.However, this hook adds a global '
wheel' event listener that intercepts and stops any horizontal scroll events. This is preventing horizontal scrolling from being implemented naturally in flow, and affects other consumers the same way.I would prefer to delete this hook altogether, but there may be other consumers that depend on this functionality. In the meantime, we can add a flag (
enableBackNavigationPrevention) to disable this hook's functionality. This gives us the ability to disable this functionality in Flow while not affecting other consumers until we're able to delete this hook in its entirety.If we delete this hook, how do we prevent accidental gesture back navigation?
The same end result can be achieved by setting the
overscroll-behavior-xproperty tocontainon the desired scroll element (e.g.ScrollArea,BaseCanvas, etc., or at page level,html)At the moment, I'm questioning the necessity of this hook, since even without it I'm unable to navigate backward from within
BaseCanvas.