Rewrite FilterQuery #264#334
Merged
mikehquan19 merged 14 commits intoUTDNebula:264-rewrite-filter-queryfrom Mar 23, 2026
Merged
Rewrite FilterQuery #264#334mikehquan19 merged 14 commits intoUTDNebula:264-rewrite-filter-queryfrom
mikehquan19 merged 14 commits intoUTDNebula:264-rewrite-filter-queryfrom
Conversation
…offest parameter, fixed multivalue parameters
Contributor
|
@SoggyRhino It's okay, thanks for the heads-up :) |
Contributor
|
Will review this this weekend. Sorry for delay. |
Contributor
|
@SoggyRhino , when you have the chance, can you redirect PR to |
…e string, added test to increase coverage
Contributor
Author
|
@mikehquan19 pr should now point to 264-rewrite-filter-query |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should resolve #264. Once again I have created a 500+ line pr but in my defense, only ~150 really counts, the rest is unit tests, documentation and adding tags.
The actual code to create the filters is relatively straight forward but it was so finicky that I ended up adding unit tests due to all the edge cases. Also I felt that doing reflection for every request was not the best so I added a cache.
Multiple values for a parameter might need to be changed but following what already existed, we just ignore after the first.
Definitely suggests changes, I'm not 100% but there is nothing that I can really think of.