fix: resolve PermissionBlock CDP unmarshal errors#137
Closed
NewdlDewdl wants to merge 1 commit intoUTDNebula:developfrom
Closed
fix: resolve PermissionBlock CDP unmarshal errors#137NewdlDewdl wants to merge 1 commit intoUTDNebula:developfrom
NewdlDewdl wants to merge 1 commit intoUTDNebula:developfrom
Conversation
Contributor
Author
|
@mikehquan19 pushed the dependency fix plus regression coverage. Verification run locally:
|
Contributor
|
Won't approve this one since it's AI-generated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #131.
Root cause: Chrome now emits newer
PrivateNetworkRequestPolicyvalues (PermissionBlock/PermissionWarn), and the pinned CDP dependency was too old to decode them. That led to repeated unmarshal errors during ChromeDP scraping.Changes in this PR:
github.com/chromedp/cdprototov0.0.0-20250803210736-d308e07a266dgithub.com/chromedp/chromedptov0.14.2for compatibility with the updated protocol packageutils/chromedp_protocol_test.goto verify enum unmarshal for old + new policy valuesVerification run:
go build ./...go test ./parser ./uploadergo test ./utils -run TestPrivateNetworkRequestPolicyUnmarshalAll pass locally.
Note: full
go test ./...still depends on local.envsecrets for existing credentialed tests inutils.