Sourcery Starbot ⭐ refactored UPSAtwal/DiscordBot_OWASP#1
Open
SourceryAI wants to merge 1 commit intoUPSAtwal:masterfrom
Open
Sourcery Starbot ⭐ refactored UPSAtwal/DiscordBot_OWASP#1SourceryAI wants to merge 1 commit intoUPSAtwal:masterfrom
SourceryAI wants to merge 1 commit intoUPSAtwal:masterfrom
Conversation
SourceryAI
commented
May 23, 2023
| self.config = {} | ||
| with open(self.configpath, "r") as file: | ||
| for i in file.readlines(): | ||
| for i in file: |
Author
There was a problem hiding this comment.
Function Config.__init__ refactored with the following changes:
- Iterate over files directly rather than using readlines() (
use-file-iterator)
| pass | ||
| def scrape(self, text, num, likes, ldate, sdate): | ||
| fQuery=fQuery="{} min_faves:{} until:{} since:{}".format(text, likes,ldate,sdate) | ||
| fQuery = fQuery = f"{text} min_faves:{likes} until:{ldate} since:{sdate}" |
Author
There was a problem hiding this comment.
Function Scraper.scrape refactored with the following changes:
- Convert for loop into dictionary comprehension (
dict-comprehension) - Replace call to format with f-string (
use-fstring-for-formatting)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for starring sourcery-ai/sourcery ✨ 🌟 ✨
Here's your pull request refactoring your most popular Python repo.
If you want Sourcery to refactor all your Python repos and incoming pull requests install our bot.
Review changes via command line
To manually merge these changes, make sure you're on the
masterbranch, then run: