feat(monitor-v2): add failure grace period to PM notifier#4939
Open
feat(monitor-v2): add failure grace period to PM notifier#4939
Conversation
Transient Polymarket API failures (timeouts, 5xx) currently trigger
immediate Slack alerts and permanently mark the proposal as handled,
preventing any retry on subsequent runs.
This adds a two-layer resiliency mechanism:
Layer 1 — Better in-process HTTP retries:
- RETRY_ATTEMPTS default 1 → 3
- RETRY_DELAY_MS default 0 → 1000 (exponential backoff)
Layer 2 — Cross-run failure grace period:
- New Datastore kind "FailedProposals" tracks proposals that fail
with firstFailureAt timestamp, failureCount, and lastError
- First failure stores a record and warns, does NOT alert
- Subsequent failures within the grace period update the record
- Only after FAILURE_GRACE_PERIOD_SECONDS (default 630s ≈ 2
serverless runs + buffer) does the alert fire
- Successful checks silently clear any prior failure record
- Setting grace period to 0 preserves the original behavior
No changes to the existing NotifiedProposals schema or notification
format.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FailedProposalsDatastore kind tracks proposals that fail with afirstFailureAttimestamp. Only afterFAILURE_GRACE_PERIOD_SECONDS(default 630s ≈ 2 serverless runs + buffer) does the alert fire. Successful checks silently clean up prior failure records. Setting to 0 preserves original behavior.RETRY_ATTEMPTSdefault 1→3 andRETRY_DELAY_MS0→1000ms for better in-process retry coverage.Test plan
gracePeriod=0behavior