Skip to content

docs[oz-retainer-07-l-04]: document reward counterparties - #62

Open
md0x wants to merge 1 commit into
pablo/fro-106-reward-cancellationfrom
pablo/oz-retainer-07-l-04-reward-counterparties-docs
Open

docs[oz-retainer-07-l-04]: document reward counterparties#62
md0x wants to merge 1 commit into
pablo/fro-106-reward-cancellationfrom
pablo/oz-retainer-07-l-04-reward-counterparties-docs

Conversation

@md0x

@md0x md0x commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator

Audit finding

OpenZeppelin Retainer 07 identified the following issue:

L-04 — Reward Increases and Decreases Use Asymmetric Counterparties, Preventing Recovery of Over-Funding

  • Severity: Low
  • Status: Open

requestManagerSetReward pulls reward increases from the request manager but refunds decreases to the original requester. A manager therefore cannot recover an accidental over-increase, and the interface should make that asymmetry explicit.

This PR is built on #56, which introduces the reward-update path reviewed by this finding.

References: OpenZeppelin audit finding · FRO-113 · audited scope tag

Resolution

  • Clarify the requestManagerSetReward interface NatSpec that reward increases are funded by the manager while decreases return funds only to the original requester.
  • State explicitly that lowering the reward cannot recover an amount previously over-funded by the request manager.
  • Preserve the existing reward-accounting behavior.
  • Documentation-only change: no behavior, ABI, event/error signature, or storage changes.

Validation

  • forge fmt --check src/optimistic-oracle-v2/interfaces/ManagedOptimisticOracleV2Interface.sol
  • forge test --match-test testRequestManagerSetRewardUsesCallerFundsAndRefundsRequester — 1 test passed
  • git diff --check

@md0x
md0x marked this pull request as ready for review August 3, 2026 10:22
@linear

linear Bot commented Aug 3, 2026

Copy link
Copy Markdown

FRO-113

@md0x
md0x requested review from Reinis-FRP and chrismaree August 3, 2026 10:22

@chrismaree chrismaree left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed at . The NatSpec now accurately documents that the manager funds increases while decreases return funds to the original requester, without changing behavior. No remaining issues.\n\n---\nSent from Chris Codex Agent 🤖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants