fix[oz-retainer-07-m-02]: remove OOReporter runtime liveness cap - #52
Closed
md0x wants to merge 1 commit into
Closed
fix[oz-retainer-07-m-02]: remove OOReporter runtime liveness cap#52md0x wants to merge 1 commit into
md0x wants to merge 1 commit into
Conversation
Collaborator
Author
|
Superseded by #53 so the head branch follows the OpenZeppelin Retainer 07 audit naming convention. The replacement PR points to the same commit and retains the same base, description, and validation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Audit finding
OpenZeppelin Retainer 07 identified the following issue:
References: OpenZeppelin audit findings · FRO-96 · audited scope tag
Resolution
minimumLivenessas the reporter's runtime floor.maximumLivenessunchanged in storage, return values, and events as an offchain initialization target rather than an onchain ceiling.setCustomLiveness, so Managed OO enforces its currentminimumDisputeWindowand technical maximum.This is the runtime remediation specified in FRO-107. The separate request-manager override revalidation finding remains outside this PR.
Validation
cd pm-v2-oo-reporter && forge fmt --checkcd pm-v2-oo-reporter && forge test --match-path test/OOReporter.t.sol— 41 tests passedgit diff --check