fix(ui5-dynamic-page): ignore zero-box focus sentinels in scroll handler - #13965
Open
NakataCode wants to merge 2 commits into
Open
fix(ui5-dynamic-page): ignore zero-box focus sentinels in scroll handler#13965NakataCode wants to merge 2 commits into
NakataCode wants to merge 2 commits into
Conversation
|
🚀 Deployed on https://pr-13965--ui5-webcomponents-preview.netlify.app |
dobrinyonkov
self-requested a review
August 21, 2026 10:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On Shift+Tab from a growing button, the Table's roving-tabindex moves focus through a transient zero-height sentinel element before landing on the real row.
DynamicPage.onContentFocusIncaptured that sentinel and calledscrollIntoViewon it, scrolling the container down and hiding the focused row.Solution
Guard the handler to bail early when the focus target has no layout box on either axis:
Real focusables always have a non-zero box on both axes; sentinels do not.
Fixes: #13935