fix(ui5-cb-item-group): expose 'title' CSS shadow part via exportparts - #13958
Open
kgogov wants to merge 1 commit into
Open
fix(ui5-cb-item-group): expose 'title' CSS shadow part via exportparts#13958kgogov wants to merge 1 commit into
kgogov wants to merge 1 commit into
Conversation
Add exportparts="title" to the ListItemGroupHeader element in ListBoxItemGroupTemplate so that ::part(title) can reach across two shadow boundaries on ui5-cb-item-group, ui5-mcb-item-group, ui5-suggestion-item-group, and ui5-search-item-group. Also add missing @csspart header and @csspart title JSDoc to ComboBoxItemGroup, MultiComboBoxItemGroup, SuggestionItemGroup, SearchItemGroup, and UserSettingsAppearanceViewGroup so the parts are documented in the generated API reference for each component. Fixes #13936
|
🚀 Deployed on https://pr-13958--ui5-webcomponents-preview.netlify.app |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
exportparts="title"to theListItemGroupHeaderelement inListBoxItemGroupTemplateso that::part(title)can reach across two shadow boundaries onui5-cb-item-group,ui5-mcb-item-group,ui5-suggestion-item-group, andui5-search-item-group.Also add missing
@csspartheader and@cssparttitle JSDoc toComboBoxItemGroup,MultiComboBoxItemGroup,SuggestionItemGroup,SearchItemGroup, andUserSettingsAppearanceViewGroupso the parts are documented in the generated API reference for each component.Fixes #13936