Skip to content

fix(charts): round x-axis bbox height to avoid subpixel re-render loop #8741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Lukas742 merged 1 commit into from
Jun 29, 2026
+2 −1
Merged

fix(charts): round x-axis bbox height to avoid subpixel re-render loop #8741

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/charts/src/hooks/useObserveXAxisHeights.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ const defaultAxisHeight = 30;
function measure(container: Element | null, axisCount: number, prevHeightsRef: MutableRefObject<number[]>) {
const heights = Array(axisCount).fill(defaultAxisHeight);
container?.querySelectorAll<SVGGraphicsElement>('.xAxis').forEach((xAxis, index) => {
const height = xAxis?.getBBox()?.height;
const height = Math.ceil(xAxis?.getBBox()?.height ?? 0);
if (height > defaultAxisHeight) {
heights[index] = height;
}
Expand All @@ -31,6 +31,7 @@ export const useObserveXAxisHeights = (chartRef: RefObject<SVGElement>, axisCoun
const [xAxisHeights, setXAxisHeights] = useState(Array(axisCount).fill(defaultAxisHeight));
const prevHeightsRef = useRef(xAxisHeights);

// TODO (v3): evaluate if ResizeObserver is better here for measuring, so it doesn't run on every component update
// check on every render if height changed
useIsomorphicLayoutEffect(() => {
const result = measure(chartRef.current, axisCount, prevHeightsRef);
Expand Down
Loading