Repository navigation
Simplify test_package_generation. - #650
Open
samcunliffe wants to merge 1 commit into
Open
samcunliffe wants to merge 1 commit into
samcunliffe wants to merge 1 commit into
Conversation
And remove the regression test + regression data.
Member
Author
|
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused assertions match fixture defaults, installation and documentation-build tests remain intact, and static review identified no blocking issues.
Review effort: Balanced
Findings: None
What changed in this PR
Simplifies Cookiecutter generation testing by replacing full snapshot comparisons with focused checks, removing duplicated generated-project data.
Changes:
- Checks generation success, required files, and selected rendered values.
- Removes snapshot comparison and automatic fixture replacement.
- Deletes the stored reference project.
| File | Description |
|---|---|
| tests/test_package_generation.py | Replaces snapshot comparison with focused assertions. |
| tests/data/test_package_generation/tests/test_dummy.py | Removes reference test. |
| tests/data/test_package_generation/src/cookiecutter_test/__init__.py | Removes reference package source. |
| tests/data/test_package_generation/README.md | Removes reference README. |
| tests/data/test_package_generation/pyproject.toml | Removes reference project configuration. |
| tests/data/test_package_generation/mkdocs.yml | Removes reference documentation configuration. |
| tests/data/test_package_generation/LICENSE.md | Removes reference license. |
| tests/data/test_package_generation/docs/LICENSE.md | Removes reference license page. |
| tests/data/test_package_generation/docs/index.md | Removes reference overview page. |
| tests/data/test_package_generation/docs/api.md | Removes reference API page. |
| tests/data/test_package_generation/CITATION.cff | Removes reference citation metadata. |
| tests/data/test_package_generation/.pre-commit-config.yaml | Removes reference hook configuration. |
| tests/data/test_package_generation/.markdownlint.yaml | Removes reference Markdown lint configuration. |
| tests/data/test_package_generation/.gitignore | Removes reference ignore rules. |
| tests/data/test_package_generation/.github/workflows/tests.yml | Removes reference test workflow. |
| tests/data/test_package_generation/.github/workflows/linting.yml | Removes reference lint workflow. |
| tests/data/test_package_generation/.github/workflows/docs.yml | Removes reference documentation workflow. |
| tests/data/test_package_generation/.github/schemas/github-issue-forms.json | Removes reference issue-form schema. |
| tests/data/test_package_generation/.github/ISSUE_TEMPLATE/question.yml | Removes reference question form. |
| tests/data/test_package_generation/.github/ISSUE_TEMPLATE/feature_request.yml | Removes reference feature-request form. |
| tests/data/test_package_generation/.github/ISSUE_TEMPLATE/documentation.yml | Removes reference documentation form. |
| tests/data/test_package_generation/.github/ISSUE_TEMPLATE/config.yml | Removes reference issue configuration. |
| tests/data/test_package_generation/.github/ISSUE_TEMPLATE/bug_report.yml | Removes reference bug-report form. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I would very much like to get rid of the complete duplication of the
{{cookiecutter.project_slug}}directory.This proposal massively simplifies
test_package_generationand removes the regression data.