Conversation
cbrasfield
reviewed
Nov 5, 2025
Comment on lines
+118
to
+119
| $config = \Drupal::config('uceap_logging.settings'); | ||
| $sensitive_fields = $config->get('sensitive_fields') ?? []; |
Contributor
There was a problem hiding this comment.
Is there a benefit to using config over state?
I guess with config you can review the file directly versus have to look in the binary blob of the database.
Member
Author
There was a problem hiding this comment.
Since the fields themselves exist in config it feels like the field list does too. Lets us cleanly deploy updates to both (new sensitive field added? new senstitive_fields config value).
cbrasfield
reviewed
Nov 5, 2025
| $config = $this->config('uceap_logging.settings'); | ||
|
|
||
| $form['sensitive_fields'] = [ | ||
| '#type' => 'textarea', |
Contributor
There was a problem hiding this comment.
I opened a PR with a suggestion to make the list selectable #3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See also