Skip to content

feat(NO-JIRA): add pnpm support to shared frontend workflows #250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bobobowis wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat(NO-JIRA): add pnpm support to shared frontend workflows #250

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
814088b
feat(TU-41409): Add pnpm support to shared frontend workflows
bobobowis Jul 8, 2026
4644638
fix(ci): address kb-typeform review feedback on pnpm support
bobobowis Jul 10, 2026
3948dd7
feat(TU-4409): Add sha to internal workflows
bobobowis Jul 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 30 additions & 14 deletions .github/workflows/frontend-deploy-workflow.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,15 @@
description: 'Use asdf-vm for version management (reads from .tool-versions)'
type: boolean
default: false
package-manager:
description: 'Package manager to use: "yarn" or "pnpm". Callers using pnpm must pass all commands explicitly.'
type: string
default: 'yarn'

# Cache configuration
# Same options as PR workflow - see frontend-pr-workflow.yml for detailed comments
cache-mode:
description: 'Cache strategy: full, node_modules-only, or yarn-cache-only'
description: 'Cache strategy: "full" (node_modules + package manager cache), "node_modules-only", "yarn-cache-only", or "pnpm-store-only"'
type: string
default: 'full'
disable-restore-keys:
Expand Down Expand Up @@ -322,19 +326,21 @@
uses: actions/checkout@v6

- name: Setup Node with Cache
uses: Typeform/.github/shared-actions/setup-node-with-cache@v1
uses: Typeform/.github/shared-actions/setup-node-with-cache@feat/pnpm-support-shared-frontend-workflows

Check failure on line 329 in .github/workflows/frontend-deploy-workflow.yml

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Use full commit SHA hash for this dependency. 


See more on https://sonarcloud.io/project/issues?id=Typeform_.github&issues=AZ9CLuKtrkAjOSPQPDKV&open=AZ9CLuKtrkAjOSPQPDKV&pullRequest=250

Check failure

Code scanning / SonarCloud

External GitHub Actions and workflows should be pinned to a commit hash High

Use full commit SHA hash for this dependency. See more on SonarQube Cloud

@bobobowis bobobowis Jul 9, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be removed before merging. It was done to simplify testing scenarios in the following repos: admin-home, smart-forms-builder, paprikations, performance-analytics

with:
node-version: ${{ inputs.node-version }}
use-asdf: ${{ inputs.use-asdf }}
cache-mode: ${{ inputs.cache-mode }}
disable-restore-keys: ${{ inputs.disable-restore-keys }}
GH_TOKEN: ${{ secrets.GH_TOKEN }}
package-manager: ${{ inputs.package-manager }}

- name: Setup Jarvis
uses: Typeform/.github/shared-actions/setup-jarvis@v1
uses: Typeform/.github/shared-actions/setup-jarvis@feat/pnpm-support-shared-frontend-workflows

Check failure on line 339 in .github/workflows/frontend-deploy-workflow.yml

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Use full commit SHA hash for this dependency. 


See more on https://sonarcloud.io/project/issues?id=Typeform_.github&issues=AZ9Cbn-Ew_HdArncfcHz&open=AZ9Cbn-Ew_HdArncfcHz&pullRequest=250

Check failure

Code scanning / SonarCloud

External GitHub Actions and workflows should be pinned to a commit hash High

Use full commit SHA hash for this dependency. See more on SonarQube Cloud

@bobobowis bobobowis Jul 9, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be removed before merging. It was done to simplify testing scenarios in the following repos: admin-home, smart-forms-builder, paprikations, performance-analytics

with:
jarvis-branch: ${{ inputs.jarvis-branch }}
GH_TOKEN: ${{ secrets.GH_TOKEN }}
package-manager: ${{ inputs.package-manager }}

- name: Run pre-build command
if: inputs.pre-build-command != ''
Expand Down Expand Up @@ -421,19 +427,21 @@
fetch-depth: 0 # Required for SonarCloud

- name: Setup Node with Cache
uses: Typeform/.github/shared-actions/setup-node-with-cache@v1
uses: Typeform/.github/shared-actions/setup-node-with-cache@feat/pnpm-support-shared-frontend-workflows

Check failure on line 430 in .github/workflows/frontend-deploy-workflow.yml

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Use full commit SHA hash for this dependency. 


See more on https://sonarcloud.io/project/issues?id=Typeform_.github&issues=AZ9CLuKtrkAjOSPQPDKW&open=AZ9CLuKtrkAjOSPQPDKW&pullRequest=250

Check failure

Code scanning / SonarCloud

External GitHub Actions and workflows should be pinned to a commit hash High

Use full commit SHA hash for this dependency. See more on SonarQube Cloud

@bobobowis bobobowis Jul 9, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be removed before merging. It was done to simplify testing scenarios in the following repos: admin-home, smart-forms-builder, paprikations, performance-analytics

@bobobowis bobobowis Jul 9, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be removed before merging. It was done to simplify testing scenarios in the following repos: admin-home, smart-forms-builder, paprikations, performance-analytics

with:
node-version: ${{ inputs.node-version }}
use-asdf: ${{ inputs.use-asdf }}
cache-mode: ${{ inputs.cache-mode }}
disable-restore-keys: ${{ inputs.disable-restore-keys }}
GH_TOKEN: ${{ secrets.GH_TOKEN }}
package-manager: ${{ inputs.package-manager }}

- name: Setup Jarvis
uses: Typeform/.github/shared-actions/setup-jarvis@v1
uses: Typeform/.github/shared-actions/setup-jarvis@feat/pnpm-support-shared-frontend-workflows

Check failure on line 440 in .github/workflows/frontend-deploy-workflow.yml

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Use full commit SHA hash for this dependency. 


See more on https://sonarcloud.io/project/issues?id=Typeform_.github&issues=AZ9Cbn-Ew_HdArncfcH0&open=AZ9Cbn-Ew_HdArncfcH0&pullRequest=250

Check failure

Code scanning / SonarCloud

External GitHub Actions and workflows should be pinned to a commit hash High

Use full commit SHA hash for this dependency. See more on SonarQube Cloud

@bobobowis bobobowis Jul 9, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be removed before merging. It was done to simplify testing scenarios in the following repos: admin-home, smart-forms-builder, paprikations, performance-analytics

with:
jarvis-branch: ${{ inputs.jarvis-branch }}
GH_TOKEN: ${{ secrets.GH_TOKEN }}
package-manager: ${{ inputs.package-manager }}

- name: Run pre-test command
if: inputs.pre-test-command != ''
Expand Down Expand Up @@ -469,23 +477,25 @@
uses: actions/checkout@v6

- name: Setup Node with Cache
uses: Typeform/.github/shared-actions/setup-node-with-cache@v1
uses: Typeform/.github/shared-actions/setup-node-with-cache@feat/pnpm-support-shared-frontend-workflows

Check failure on line 480 in .github/workflows/frontend-deploy-workflow.yml

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Use full commit SHA hash for this dependency. 


See more on https://sonarcloud.io/project/issues?id=Typeform_.github&issues=AZ9CLuKtrkAjOSPQPDKX&open=AZ9CLuKtrkAjOSPQPDKX&pullRequest=250

Check failure

Code scanning / SonarCloud

External GitHub Actions and workflows should be pinned to a commit hash High

Use full commit SHA hash for this dependency. See more on SonarQube Cloud

@bobobowis bobobowis Jul 9, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be removed before merging. It was done to simplify testing scenarios in the following repos: admin-home, smart-forms-builder, paprikations, performance-analytics

@bobobowis bobobowis Jul 9, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be removed before merging. It was done to simplify testing scenarios in the following repos: admin-home, smart-forms-builder, paprikations, performance-analytics

with:
node-version: ${{ inputs.node-version }}
use-asdf: ${{ inputs.use-asdf }}
cache-mode: ${{ inputs.cache-mode }}
disable-restore-keys: ${{ inputs.disable-restore-keys }}
GH_TOKEN: ${{ secrets.GH_TOKEN }}
package-manager: ${{ inputs.package-manager }}

- name: Setup Jarvis
uses: Typeform/.github/shared-actions/setup-jarvis@v1
uses: Typeform/.github/shared-actions/setup-jarvis@feat/pnpm-support-shared-frontend-workflows

Check failure on line 490 in .github/workflows/frontend-deploy-workflow.yml

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Use full commit SHA hash for this dependency. 


See more on https://sonarcloud.io/project/issues?id=Typeform_.github&issues=AZ9GzWT0cuk8hGTdp3sX&open=AZ9GzWT0cuk8hGTdp3sX&pullRequest=250

Check failure

Code scanning / SonarCloud

External GitHub Actions and workflows should be pinned to a commit hash High

Use full commit SHA hash for this dependency. See more on SonarQube Cloud
with:
jarvis-branch: ${{ inputs.jarvis-branch }}
GH_TOKEN: ${{ secrets.GH_TOKEN }}
package-manager: ${{ inputs.package-manager }}

- name: Setup Playwright
if: inputs.integration-test-framework == 'playwright'
uses: Typeform/.github/shared-actions/setup-playwright@v1
uses: Typeform/.github/shared-actions/setup-playwright@feat/pnpm-support-shared-frontend-workflows

Check failure on line 498 in .github/workflows/frontend-deploy-workflow.yml

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Use full commit SHA hash for this dependency. 


See more on https://sonarcloud.io/project/issues?id=Typeform_.github&issues=AZ9Cbn-Ew_HdArncfcH1&open=AZ9Cbn-Ew_HdArncfcH1&pullRequest=250

Check failure

Code scanning / SonarCloud

External GitHub Actions and workflows should be pinned to a commit hash High

Use full commit SHA hash for this dependency. See more on SonarQube Cloud

@bobobowis bobobowis Jul 9, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be removed before merging. It was done to simplify testing scenarios in the following repos: admin-home, smart-forms-builder, paprikations, performance-analytics


- name: Run pre-test command
if: inputs.pre-test-command != ''
Expand Down Expand Up @@ -529,7 +539,7 @@

steps:
- name: Run Cypress Functional Tests
uses: Typeform/.github/shared-actions/run-cypress-functional@v1
uses: Typeform/.github/shared-actions/run-cypress-functional@feat/pnpm-support-shared-frontend-workflows

Check failure on line 542 in .github/workflows/frontend-deploy-workflow.yml

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Use full commit SHA hash for this dependency. 


See more on https://sonarcloud.io/project/issues?id=Typeform_.github&issues=AZ9CLuKtrkAjOSPQPDKY&open=AZ9CLuKtrkAjOSPQPDKY&pullRequest=250

Check failure

Code scanning / SonarCloud

External GitHub Actions and workflows should be pinned to a commit hash High

Use full commit SHA hash for this dependency. See more on SonarQube Cloud

@bobobowis bobobowis Jul 9, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be removed before merging. It was done to simplify testing scenarios in the following repos: admin-home, smart-forms-builder, paprikations, performance-analytics

with:
node-version: ${{ inputs.node-version }}
use-asdf: ${{ inputs.use-asdf }}
Expand All @@ -544,6 +554,7 @@
artifact-retention-days: '7'
GH_TOKEN: ${{ secrets.GH_TOKEN }}
CYPRESS_RECORD_KEY: ${{ secrets.CYPRESS_RECORD_KEY }}
package-manager: ${{ inputs.package-manager }}

# Job 5: Cypress Visual Tests (runs in parallel with other tests)
cypress-visual:
Expand All @@ -555,7 +566,7 @@

steps:
- name: Run Cypress Visual Tests
uses: Typeform/.github/shared-actions/run-cypress-visual@v1
uses: Typeform/.github/shared-actions/run-cypress-visual@feat/pnpm-support-shared-frontend-workflows

Check failure on line 569 in .github/workflows/frontend-deploy-workflow.yml

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Use full commit SHA hash for this dependency. 


See more on https://sonarcloud.io/project/issues?id=Typeform_.github&issues=AZ9CLuKtrkAjOSPQPDKZ&open=AZ9CLuKtrkAjOSPQPDKZ&pullRequest=250

Check failure

Code scanning / SonarCloud

External GitHub Actions and workflows should be pinned to a commit hash High

Use full commit SHA hash for this dependency. See more on SonarQube Cloud

@bobobowis bobobowis Jul 9, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be removed before merging. It was done to simplify testing scenarios in the following repos: admin-home, smart-forms-builder, paprikations, performance-analytics

with:
node-version: ${{ inputs.node-version }}
use-asdf: ${{ inputs.use-asdf }}
Expand All @@ -575,6 +586,7 @@
VRT_APIURL: ${{ secrets.VRT_APIURL }}
VRT_APIKEY: ${{ secrets.VRT_APIKEY }}
VRT_PROJECT: ${{ secrets.VRT_PROJECT }}
package-manager: ${{ inputs.package-manager }}

# Job 6: Playwright Visual Tests (runs in parallel with other tests)
playwright-visual:
Expand All @@ -586,7 +598,7 @@

steps:
- name: Run Playwright Visual Tests
uses: Typeform/.github/shared-actions/run-playwright-visual@v1
uses: Typeform/.github/shared-actions/run-playwright-visual@feat/pnpm-support-shared-frontend-workflows

Check failure on line 601 in .github/workflows/frontend-deploy-workflow.yml

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Use full commit SHA hash for this dependency. 


See more on https://sonarcloud.io/project/issues?id=Typeform_.github&issues=AZ9CLuKtrkAjOSPQPDKa&open=AZ9CLuKtrkAjOSPQPDKa&pullRequest=250

Check failure

Code scanning / SonarCloud

External GitHub Actions and workflows should be pinned to a commit hash High

Use full commit SHA hash for this dependency. See more on SonarQube Cloud

@bobobowis bobobowis Jul 9, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be removed before merging. It was done to simplify testing scenarios in the following repos: admin-home, smart-forms-builder, paprikations, performance-analytics

with:
node-version: ${{ inputs.node-version }}
use-asdf: ${{ inputs.use-asdf }}
Expand All @@ -606,6 +618,7 @@
VRT_APIURL: ${{ secrets.VRT_APIURL }}
VRT_APIKEY: ${{ secrets.VRT_APIKEY }}
VRT_PROJECT: ${{ secrets.VRT_PROJECT }}
package-manager: ${{ inputs.package-manager }}

# Job 7: SonarCloud Analysis (waits for unit tests if enabled)
sonarcloud:
Expand All @@ -614,14 +627,15 @@
needs: [build, unit-tests, check-verification]
permissions:
contents: read
uses: Typeform/.github/.github/workflows/sonarcloud-scan.yml@v1
uses: Typeform/.github/.github/workflows/sonarcloud-scan.yml@feat/pnpm-support-shared-frontend-workflows

Check failure on line 630 in .github/workflows/frontend-deploy-workflow.yml

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Use full commit SHA hash for this dependency. 


See more on https://sonarcloud.io/project/issues?id=Typeform_.github&issues=AZ9CN79Ko-H3ZaYCo-HP&open=AZ9CN79Ko-H3ZaYCo-HP&pullRequest=250

Check failure

Code scanning / SonarCloud

External GitHub Actions and workflows should be pinned to a commit hash High

Use full commit SHA hash for this dependency. See more on SonarQube Cloud

@bobobowis bobobowis Jul 9, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be removed before merging. It was done to simplify testing scenarios in the following repos: admin-home, smart-forms-builder, paprikations, performance-analytics

with:
app-name: ${{ inputs.app-name }}
node-version: ${{ inputs.node-version }}
use-asdf: ${{ inputs.use-asdf }}
runner: ${{ inputs.runner }}
coverage-artifact-name: ${{ inputs.run-unit-tests && format('coverage-{0}', github.run_id) || '' }}
timeout: ${{ inputs.sonarcloud-timeout }}
package-manager: ${{ inputs.package-manager }}
secrets:
GH_TOKEN: ${{ secrets.GH_TOKEN }}
SONAR_CLOUD_TOKEN: ${{ secrets.SONAR_CLOUD_TOKEN }}
Expand Down Expand Up @@ -666,13 +680,14 @@
git config --global user.email "${{ github.actor }}@users.noreply.github.com"

- name: Setup Node with Cache
uses: Typeform/.github/shared-actions/setup-node-with-cache@v1
uses: Typeform/.github/shared-actions/setup-node-with-cache@feat/pnpm-support-shared-frontend-workflows

Check failure on line 683 in .github/workflows/frontend-deploy-workflow.yml

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Use full commit SHA hash for this dependency. 


See more on https://sonarcloud.io/project/issues?id=Typeform_.github&issues=AZ9CLuKtrkAjOSPQPDKb&open=AZ9CLuKtrkAjOSPQPDKb&pullRequest=250

Check failure

Code scanning / SonarCloud

External GitHub Actions and workflows should be pinned to a commit hash High

Use full commit SHA hash for this dependency. See more on SonarQube Cloud

@bobobowis bobobowis Jul 9, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be removed before merging. It was done to simplify testing scenarios in the following repos: admin-home, smart-forms-builder, paprikations, performance-analytics

with:
node-version: ${{ inputs.node-version }}
use-asdf: ${{ inputs.use-asdf }}
cache-mode: ${{ inputs.cache-mode }}
disable-restore-keys: ${{ inputs.disable-restore-keys }}
GH_TOKEN: ${{ secrets.GH_TOKEN }}
package-manager: ${{ inputs.package-manager }}

- name: Download Build Artifacts
uses: Typeform/.github/shared-actions/download-build-artifacts@v1
Expand All @@ -681,10 +696,11 @@
output-dir: ${{ inputs.build-artifact-download-path || inputs.build-output-dir }}

- name: Setup Jarvis
uses: Typeform/.github/shared-actions/setup-jarvis@v1
uses: Typeform/.github/shared-actions/setup-jarvis@feat/pnpm-support-shared-frontend-workflows

Check failure on line 699 in .github/workflows/frontend-deploy-workflow.yml

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Use full commit SHA hash for this dependency. 


See more on https://sonarcloud.io/project/issues?id=Typeform_.github&issues=AZ9Cbn-Ew_HdArncfcH2&open=AZ9Cbn-Ew_HdArncfcH2&pullRequest=250

Check failure

Code scanning / SonarCloud

External GitHub Actions and workflows should be pinned to a commit hash High

Use full commit SHA hash for this dependency. See more on SonarQube Cloud

@bobobowis bobobowis Jul 9, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be removed before merging. It was done to simplify testing scenarios in the following repos: admin-home, smart-forms-builder, paprikations, performance-analytics

with:
jarvis-branch: ${{ inputs.jarvis-branch }}
GH_TOKEN: ${{ secrets.GH_TOKEN }}
package-manager: ${{ inputs.package-manager }}

- name: AWS auth
uses: Typeform/.github-private/actions/aws-auth@aws-auth-0.0.2
Expand Down
12 changes: 11 additions & 1 deletion .github/workflows/frontend-library-pr-release-workflow.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,16 @@ on:
description: 'Job timeout in minutes'
type: number
default: 15

package-manager:
description: 'Package manager to use: "yarn" or "pnpm". Callers using pnpm must pass all commands explicitly.'
type: string
default: 'yarn'

semantic-release-command:
description: 'Semantic release command. Callers using pnpm must pass all commands explicitly.'
type: string
default: 'yarn semantic-release'

secrets:
GH_TOKEN:
Expand Down Expand Up @@ -107,7 +117,7 @@ jobs:
if: |
inputs.run-semantic-release &&
contains(fromJSON(inputs.semantic-release-branches), github.ref_name)
run: yarn semantic-release
run: ${{ inputs.semantic-release-command }}
env:
GH_TOKEN: ${{ secrets.GH_TOKEN }}
NPM_TOKEN: ${{ secrets.GH_TOKEN }}
Expand Down
Loading