test(env): cover the config-file parser and run-dir cleanup guard#820
Merged
Conversation
load_config_file evals export lines from .bashunitrc, but only its happy path had (acceptance-level) coverage. Add unit tests for the parser's edges: comments/blank lines, 'export ' prefix and quote stripping, env-over-file precedence, invalid-identifier rejection, missing-file no-op — and the security-relevant property that a command substitution in a value is stored as literal text and a key carrying shell metacharacters is skipped, never evaled. Also covers cleanup_run_output_dir (#811): removes a proper run dir, refuses (exit 1, files intact) any path outside */bashunit/run/*.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 Background
load_config_fileevalsexportlines from.bashunitrc; only its happy path had acceptance-level coverage. Its edge cases — including the injection guard — were untested, as was thecleanup_run_output_dirsafety check from #811.💡 Changes
exportprefix + quote stripping, env-over-file precedence, invalid-identifier rejection, missing-file no-op.cleanup_run_output_dir: removes a real run dir; refuses (exit 1, files intact) anything outside*/bashunit/run/*.