docs: record parallel fork budget and the mktemp-uniqueness constraint#814
Merged
Conversation
Updates the fork-budget rule with the #813 results: the parallel per-test publishing patterns (parent pre-creates the workers' dir; skip sanitizing on empty input), the measured parallel budget (61 -> 21 forks per 10-test run), why the remaining per-test mktemp cannot become a deterministic name on Bash 3 (subshells share $$ and RANDOM state; BASHPID is 4.0+), and two explicit don't-fix notes (wait_for_job_slot, spinner).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 Background
Follow-up to #812/#813: the fork-budget rule predates the parallel-mode profiling and says "per-test cost is fork-free", which is inaccurate for
--parallel(onemktempper test remains, for a provable reason).💡 Changes
mktempcan't become a deterministic name on Bash 3 ($$/RANDOMshared by subshells,BASHPIDis 4.0+) and two explicit don't-fix notes (wait_for_job_slot, spinner).