perf(runner): list functions with compgen builtin, not declare -F | awk#810
Merged
Conversation
Three call sites captured the defined-function list by piping 'declare -F' through an awk fork. 'compgen -A function' is a bash builtin producing the identical name-per-line output (both alphabetical), so the capture costs only its subshell. 5 -> 3 awk forks per test file; the remainder are the per-file file scans (provider map x2, duplicate check). No behaviour change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 Background
Continuing the fork-reduction series (#801-#809). Three call sites captured the defined-function list by piping
declare -Fthrough anawkfork.💡 Changes
compgen -A functionbuiltin — identical name-per-line, alphabetical output — so the capture costs only its subshell (5 → 3awkforks per test file).