fix(runner): stop get_function_line_number clobbering caller extdebug#808
Merged
Merged
Conversation
get_function_line_number ran 'shopt -s extdebug' then 'shopt -u extdebug' in the caller's shell, so a caller that already had extdebug enabled was silently left with it disabled. Enable it only inside the subshell that reads the declaration, and parse the line number from 'declare -F' output with shell word-splitting instead of forking awk. Fixes the state leak and removes one fork per lookup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 Background
bashunit::helper::get_function_line_numberenabledextdebugand then ranshopt -u extdebugin the caller's shell, so a caller that already hadextdebugon was silently left with it off.💡 Changes
extdebugonly inside the subshell that reads the declaration, leaving the caller's setting untouched.declare -Foutput with shell word-splitting instead of forkingawk.