perf(runner): read failing-test body once for Source: context#807
Merged
Conversation
get_failure_source_context re-read the test file with a 'sed -n Np' fork for every line of the function body and a 'grep' fork to detect the closing brace, so fork count grew with function length (a 20-line body cost ~46 forks). Read the body in a single bash 'read' loop and detect the closing brace by trimming whitespace — no per-line forks (~46 -> ~2). Output is byte-identical (failure snapshots unchanged). No behaviour change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 Background
Profiling a failing test surfaced quadratic fork behaviour:
get_failure_source_contextre-read the test file with ased -n Npfork per line and agrepfork per line to find the function's closing brace, so the fork count grew with the function length.💡 Changes
readloop and detect the closing brace by trimming whitespace — no per-linesed/grepforks (a 20-line body dropped from ~46 to ~2 forks).