perf(runner): emit per-test result payload with printf, not cat#806
Merged
Conversation
export_subshell_context emitted the encoded result payload via a `cat <<EOF` heredoc, forking cat once per test. Build the same single line with a `\`-continued string and print it with `printf` (a builtin) — no fork per test. Output is byte-identical, so the result parser is unaffected. No behaviour change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 Background
Profiling a multi-test run surfaced a per-test fork:
export_subshell_contextemitted the encoded result payload with acat <<EOFheredoc — onecatprocess per test.💡 Changes
\-continued string and print it withprintf(a builtin) — no fork per test.