perf(runner): match source/pattern probes with case, drop 2 grep forks#804
Merged
Conversation
Two per-file grep forks in the run path became shell case matches: - runner: scanning sourcing stderr for 'syntax error'/'unexpected EOF' - discovery: deciding whether to also match the .bash pattern variant 2 -> 0 grep forks per sourced test file; matters across the acceptance suite's ~258 nested runs. No behaviour change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 Background
Continuing the fork reduction from #798/#802/#803, now on the per-file run path. Running a test file forked
greptwice per sourced file.💡 Changes
syntax error/unexpected EOFwith a shellcaseinstead of agrepfork..bashpattern variant with acaseinstead of agrepfork.grepforks per sourced test file (matters across the acceptance suite's ~258 nested runs); regression test added. No behaviour change.